Hkl utils #76
Hkl utils #76
Conversation
simplify setor1
file formatting
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 35.95% 32.88% -3.08%
==========================================
Files 11 11
Lines 1777 1943 +166
==========================================
Hits 639 639
- Misses 1138 1304 +166
|
add function to remove reflection from list
change order of arguments in setor0 and setor1
implement functions write_config and read_config
Modify write_config
changes in write_config
implement function functions() to list available functions
update functions()
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
polartools/hkl_utils.py
Outdated
| ) | ||
|
|
||
|
|
||
| from inspect import getmembers, isfunction |
There was a problem hiding this comment.
The error in flake8 is a style one and comes from these imports in the middle of the file. You need to move them to the top.
polartools/hkl_utils.py
Outdated
| from hklpy.hkl import user, util | ||
|
|
||
|
|
||
| def functions(select="all"): |
There was a problem hiding this comment.
I'm not sure what this function does.
fix style
remove blanks
use black -l 80 instead of -l 79
update functions()
help added to new functions
modify function_list in functions()
simplify code for inputs
fix error in string
fix print in sampleList
fix error in set_orienting
implement e4c in sampleList
fix indentation, black
fix index for e4c
implement fourc
add function set_experiment()
fix bug in setor0/1 remove commented lines
setor0/1
black formatting
fix bug in or1()
add function update_lattice()
black formatting
replace 'diffract and 'fourc' by check for number of axes. Remove list_functions() and set_experiment()
fix issues in update_lattice
remove comments
black
| omega=float(th), | ||
| chi=float(chi), | ||
| phi=float(phi), | ||
| gamma=float(gamma), |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
| chi=float(chi), | ||
| phi=float(phi), | ||
| gamma=float(gamma), | ||
| mu=float(mu), |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
| omega=float(th), | ||
| chi=float(chi), | ||
| phi=float(phi), | ||
| gamma=float(gamma), |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
| chi=float(chi), | ||
| phi=float(phi), | ||
| gamma=float(gamma), | ||
| mu=float(mu), |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
change Theta to Eta and Gamma to Nu
black formatting
add else statements
add output text to read_config
fix bug in write_config
Add _geom_=current_diffractometer() to all functions.
change _geom_.forward to first orienting reflection and add UB-calc into read_config()
add compute_UB in functions
Fix errors
simplify
add else statements
No description provided.