Skip to content

Use React.PureComponent instead shallowCompare #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

artkow
Copy link

@artkow artkow commented Apr 25, 2017

@@ -16,8 +16,7 @@
"ios"
],
"dependencies": {
"react-native-vector-icons": ">=1.0.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native-vector-icons should still be a dependency. Please do not remove it :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native-vector-icons is not touched and all the time is in dependency, only last character was removed from this line.
Please check again my PR and correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants