Allow scroll to a specific position #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great @nlively! Will merge today. |
lib/KeyboardAwareMixin.js
Outdated
| this.keyboardWillHideEvent.remove() | ||
| }, | ||
|
|
||
| scrollToPosition: function(x, y) { |
There was a problem hiding this comment.
I would like to have three things before merging this PR:
- Please insert an space between
functionand the parens. - Add Flow annotations.
- Add also a third parameter to programatically set the
animatedvalue.
In the end, it would look like this:
scrollToPosition: function (x: number, y: number, animated: bool = false) {
...
}
|
Please @nlively consider adding my suggestions and I'll be more than happy to merge this PR. |
Applied suggestions from @APSL to add the `animated` parameter to this function and specify flow annotations
|
@alvaromb, I've added them. Please take a look. Thanks! |
|
+1 This is greate! Just what I need. |
|
Merged! |
|
Will release |
alvaromb
added a commit
that referenced
this pull request
May 31, 2016
* Adds support for auto TextInput onFocus scroll Adds support for auto TextInput onFocus scroll Allow scroll to a specific position (#19) * allow scroll to a specific position * Update KeyboardAwareMixin.js Applied suggestions from @APSL to add the `animated` parameter to this function and specify flow annotations * Improved README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request exposes a method that allows direct scrolling