Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ec2 info and add script to regenerate #148

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

wllgrnt
Copy link
Contributor

@wllgrnt wllgrnt commented Sep 14, 2023

Motivation and Context

The EC2 dictionary was out of date, so I pulled a new list of instance types from a third-party website

How Has This Been Tested?

Wrote a script comparing the new and old dictionary versions - some of the old keys no longer exist but otherwise all values match (except one cost being wrong by one cent) .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@wllgrnt wllgrnt changed the base branch from dev to will-update-chrome-driver-url September 14, 2023 19:31
@wllgrnt wllgrnt changed the base branch from will-update-chrome-driver-url to dev September 14, 2023 19:47
@atzannes
Copy link
Contributor

atzannes commented Sep 26, 2023

@wllgrnt how about instead of embedding the JSON output of your script into the python code, we just load it? This will make updating it easier. The caveat is that when you call createOrUpdateService for the AwsBooterService, you need to pass extensions=(".py", ".json")

@braxtonmckee what's your preference?

@atzannes atzannes merged commit 0a0fad0 into dev Sep 29, 2023
9 checks passed
@atzannes atzannes deleted the will-update-ec2-info branch September 29, 2023 18:29
@wllgrnt wllgrnt mentioned this pull request Oct 5, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants