Build modification aimed to fix multiple instances of three #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instances of threejs error when importing both `three` and the `threex-location-only` - Also modified `build` and `build:dev` scripts to use `webpack` instead of `./node_modules/.bin/webpack`. It was producing an error in my machine.
|
@juanRabaa thanks, will give this a go. @kalwalt do you also want to review this? |
|
(sorry for late reply by the way, it's been a while since I've had the chance to look at AR.js). |
I hope to have some spare time after the 7 january, it was on my radar but i haven't had the time... |
|
@juanRabaa finally got round to looking at your PR, many apologies for the delay. I still get the "multiple instances" warning in my test code, which is tutorial 1 from the docs: https://ar-js-org.github.io/AR.js-Docs/location-based-three/ modified to use your build, e.g Does this work for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Can it be referenced to an Issue? If so what is the issue # ?
#504
How can we test it?
Run build and import
three.js/build/ar-threex-location-only.js. I made a package of this fork to test this out and seems to work fine.Summary
threex-location-onlyoutput mode tomoduleto fix multiple instances of threejs error when importing boththreeand thethreex-location-onlybuildandbuild:devscripts to usewebpackinstead of./node_modules/.bin/webpack. It was producing an error in my machine and I guess others. It should work in every machine with justwebpack.Does this PR introduce a breaking change?
This will limit the
threex-location-onlybuild to be used only as a module. I think, if needed, more than one build can be made, one with the previous configuration UMD . I don't expect this to be merged as is, there probably is a better solution.Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
OS: Windows 10
Browser: Chrome V.116.0.5845.141