Fixing Analytics Entity

ARCANEDEV · Oct 21, 2015 · a4f2303 · a4f2303
1 parent f1e6638
commit a4f2303
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/Entities/Analytics.php b/src/Entities/Analytics.php
@@ -35,11 +35,11 @@ class Analytics implements AnalyticsInterface
     /**
      * Make an Analytics instance.
      *
-     * @param  array  $config
+     * @param  array  $configs
      */
-    public function __construct(array $config)
+    public function __construct(array $configs = [])
     {
-        $this->setConfigs($config);
+        $this->setConfigs($configs);
 
         $this->setGoogle($this->getConfig('google', ''));
     }
@@ -99,6 +99,10 @@ public function __toString()
      */
     private function renderGoogleScript()
     {
+        if (empty($this->google)) {
+            return '';
+        }
+
         return <<<EOT
 <script>
     (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){

diff --git a/tests/Entities/AnalyticsTest.php b/tests/Entities/AnalyticsTest.php
@@ -54,6 +54,14 @@ public function it_can_be_instantiated()
         }
     }
 
+    /** @test */
+    public function it_must_render_empty_on_init()
+    {
+        $this->analytics = new Analytics;
+
+        $this->assertEmpty($this->analytics->render());
+    }
+
     /** @test */
     public function it_can_render()
     {