-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: read_mmcr
method to read ARM MMCR b1-level data files
#1704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment, besides that looks good. @mgrover1 can give this a review as well, when you have time?
… of hardwired handbook values
I just added options to read dual-pol channels' MMCR data (limited number of data files). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @isilber for putting this together
@zssherman - did you need to take another look? Otherwise, we are good to merge! |
Nope, merge away! Thanks again @isilber ! |
A method to robustly read ARM MMCR b1-level data files (the datastream available through the ARM Archive).
The method returns a
dict
with keys representing each of the operated MMCR modes (available in the data files) and values representing the correspondingRadar
objects. An optional input parameter (mode_to_extract
) enables only extracting a single mode, in which case a singleRadar
object is returned.The method is written in a similar format to the
read_kazr
method (which has some clutter in it) under the sameaux_io
module.That module lacks unit tests (as also noted in its
__init__.py
script) and therefore I didn't include unit tests.