Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: read_mmcr method to read ARM MMCR b1-level data files #1704

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

isilber
Copy link
Contributor

@isilber isilber commented Dec 10, 2024

A method to robustly read ARM MMCR b1-level data files (the datastream available through the ARM Archive).
The method returns a dict with keys representing each of the operated MMCR modes (available in the data files) and values representing the corresponding Radar objects. An optional input parameter (mode_to_extract) enables only extracting a single mode, in which case a single Radar object is returned.

The method is written in a similar format to the read_kazr method (which has some clutter in it) under the same aux_io module.
That module lacks unit tests (as also noted in its __init__.py script) and therefore I didn't include unit tests.

  • [ x] Documentation reflects changes

@isilber isilber requested a review from zssherman as a code owner December 10, 2024 22:57
Copy link
Collaborator

@zssherman zssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment, besides that looks good. @mgrover1 can give this a review as well, when you have time?

@isilber
Copy link
Contributor Author

isilber commented Dec 11, 2024

I just added options to read dual-pol channels' MMCR data (limited number of data files).
I also changed the PRT specifications to be read from the loaded file instead of hardwired handbook values

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @isilber for putting this together

@mgrover1
Copy link
Collaborator

@zssherman - did you need to take another look? Otherwise, we are good to merge!

@zssherman
Copy link
Collaborator

Nope, merge away! Thanks again @isilber !

@zssherman zssherman merged commit 28c16de into ARM-DOE:main Dec 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants