Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml and json output format #33

Merged
merged 6 commits into from
Apr 17, 2023
Merged

Add xml and json output format #33

merged 6 commits into from
Apr 17, 2023

Conversation

arekzaluski
Copy link
Contributor

@arekzaluski arekzaluski commented Apr 3, 2023

Why

It is very difficult to parse existing txt output. Addition of xml and json will allow the output to be easily parsable by other tools/extensions.

Changes

  • Add xml and json option to format output
    It will print events and event statistics as xml/json file or on stdout.

Example:

eventlist -f json -o output.json <logFile>

@jkrech jkrech requested a review from bgn42 April 4, 2023 06:25
@JonatanAntoni
Copy link
Member

@arekzaluski, could you address the lint warnings, please?

@arekzaluski
Copy link
Contributor Author

@JonatanAntoni @bgn42 I've fixed linting issues and added tests for xml and json. It's ready to be rechecked.

@JonatanAntoni JonatanAntoni requested a review from bgn42 April 17, 2023 08:03
@codecov-commenter
Copy link

Codecov Report

Merging #33 (d8b2ef4) into main (224c8c4) will increase coverage by 0.06%.
The diff coverage is 95.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   96.77%   96.84%   +0.06%     
==========================================
  Files           9        9              
  Lines        3321     3389      +68     
==========================================
+ Hits         3214     3282      +68     
- Misses         73       74       +1     
+ Partials       34       33       -1     
Impacted Files Coverage Δ
tools/eventlist/pkg/output/output.go 89.53% <94.87%> (+1.67%) ⬆️
tools/eventlist/cmd/eventlist/main.go 97.52% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@bgn42 bgn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good now.

@JonatanAntoni JonatanAntoni merged commit 47c1f75 into ARM-software:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants