-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[github.io] Convert acle rst to md #134
[github.io] Convert acle rst to md #134
Conversation
277838d
to
ba1c3b6
Compare
ba1c3b6
to
ed4caf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ValeriaDaneva - unfortunately this PR needs some re-work. There are too many changes in the rst-to-md content change (the second commit) that are unrelated to the syntax change. The huge amount of changes that are not really needed makes it quite difficult to review.
Most of the unrelated changes seems to be coming from situations like the following:
In cases like this, a simple change like replacing the syntax for fixed font text, which would have resulted in one line change in the patch, have become a 4 or 5 line change for a simple rearrangement of the text in the lines. This is (probably) due to the script that you have used to remove the wrong syntax generated by pandoc?
Please go through the rst-to-md content change again and minimize the amount of changes that need to be done for these kind of things. This will make it easier to review, and will also increase the guarantee that what we have is just a syntax change and not a content change. Right now I would have to go through all the paragraphs to make sure that the text is correct to be able to tell if we can merge the patch. Too risky and error prone.
There are also paragraphs that show as changed although there are no real changes in it, just a different length of the line. We better keep those paragraphs to the original version.
I suspect that these useless changes have been introduced by the automatic line justification introduced by pandoc in the conversion process...
24b4a38
to
dc1742e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ValeriaDaneva - thank you for simplifying the changes, this made it much easier to review.
Now, I have left many comments, but most of them are duplicate instances of two issues.
- The syntax for wrapping C code is not
c ...
, but triple, followed by c. However, we don't want to introduce C syntax highlighting in this change, just wrap the code with triple
- Some code (mostly intrinsic definitions) was originally written in rst with the syntax that uses ::. This syntx renders the text as a separate paragraph, not inline. You have replaced this rst syntax with single
wrapping, which renders it inline. You have to change these instances by wrapping them with a triple
.
There are many instances of both 1. and 2., I haven't marked them all.
Thank you for your patience, we are getting there!
Francesco
dc1742e
to
0a8d796
Compare
0a8d796
to
e1521f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ValeriaDaneva ! LGTM
No description provided.