Vector library cleanup #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1307,7 +1307,7 @@ unsigned int compute_ideal_endpoint_formats( | |||
| vmask lanes_min_error = vbest_ep_error == hmin(vbest_ep_error); | |||
| vbest_error_index = select(vint(0x7FFFFFFF), vbest_error_index, lanes_min_error); | |||
| vbest_error_index = hmin(vbest_error_index); | |||
| int best_error_index = vbest_error_index.lane<0>(); | |||
| int best_error_index = vbest_error_index.lane0(); | |||
There was a problem hiding this comment.
You squished out the other lane0 accesses into hmax_s etc... any reason not to wrap this one?
Source/UnitTest/test_simd.cpp
Outdated
| @@ -169,8 +203,8 @@ TEST(vfloat, ChangeSign) | |||
| /** @brief Test VLA atan. */ | |||
| TEST(vfloat, Atan) | |||
| { | |||
| vfloat a(-0.15f, 0.0f, 0.9f, 2.1f); | |||
| vfloat r = atan(a); | |||
| vfloa4 a(-0.15f, 0.0f, 0.9f, 2.1f); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The astcenc vector library effectively implements two different class APIs:
vfloat4) in the codec.vfloat) in the codec, and where the width is resolved at compile time.For historical reasons the classes that are only used as a VLA classes (e.g.
vfloat8for AVX2) implement a lot of functionality which was inherited from the original 4-wide implementation and not actually used in the VLA parts of the codec. This makes adding new VLA implementation (e.g. Arm SVE) more expensive than it needs to be.This PR doesn't add SVE support, but does some cleanup to minimize the vector library API as a precursor to doing so. The main changes are:
.lane<0>()with dedicated scalar function returns e.g. usehmax_s()rather thanhmax.lane<0>(). This was beeing done in places before, but was not done consistently. Now this pattern is used everywhere.