This repository has been archived by the owner on Nov 26, 2021. It is now read-only.
trappy/cache: Store the csv in utf-8 charset explicitly #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we load the files from trace-cmd output, we explicitly choose to load them using utf-8. This means we may have characters in our trace which cannot be represented in ascii, which makes pandas upset when we try to store the parsed dataframes in the csv cache. This is not an issue for Python3 versions, as the to_csv method defaults to utf-8, whilst the Python2 to_csv method defaults to ascii. Signed-off-by: Chris Redpath <chris.redpath@arm.com>
|
Travis doesn't seem to like it, can you have a look as to why? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we load the files from trace-cmd output, we explicitly choose
to load them using utf-8. This means we may have characters in
our trace which cannot be represented in ascii, which makes pandas
upset when we try to store the parsed dataframes in the csv cache.
This is not an issue for Python3 versions, as the to_csv method
defaults to utf-8, whilst the Python2 to_csv method defaults to
ascii.
Signed-off-by: Chris Redpath chris.redpath@arm.com