Provide support for BLE GattClient Adaptation Layer #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-
commented
Sep 27, 2017
There was a problem hiding this comment.
Would it be possible to detail what the following functions do:
- aci_gatt_read_charac_val: Does it send a single ATT read request ?
- aci_gatt_read_long_charac_val: Does it sends automatically multiple ATT Read Blob Request and therefore receive multiple Read Blob responses ?
- aci_gatt_read_multiple_charac_val: Does it send a single ATT Read multiple response ?
- aci_gatt_write_charac_value: Does it send a single ATT write request ?
Command complete should be handled for:
- aci_gatt_exchange_configuration
- aci_gatt_write_without_response
- aci_gatt_signed_write_without_resp
I think command complete should be handled via a set of procedure control block, which use the connection handle as identification key (More on that latter).
| @@ -397,7 +397,7 @@ extern "C" { | |||
| evt_disconn_complete *evt = (evt_disconn_complete*)event_pckt->data; | |||
|
|
|||
| if(BlueNRGGap::getInstance().getGapRole() == Gap::CENTRAL) { | |||
| BlueNRGGattClient::getInstance().removeGattConnectionClient(evt->handle, evt->reason); | |||
| //ble::pal::st::BlueNRGGattClient::getInstance().terminate(); | |||
There was a problem hiding this comment.
I suppose this comment and the condition can be removed.
| case EVT_BLUE_GATT_PROCEDURE_COMPLETE: | ||
| case EVT_BLUE_GATT_ERROR_RESP: | ||
| { | ||
| ble::pal::st::BlueNRGGattClient::getInstance().aci_event_cb(blue_evt); |
There was a problem hiding this comment.
Is it mandatory to check the event code ?
aci_event_cb will also check the event code.
I think aci_event_cb can be invoked in the default case.
| case BLE_STATUS_SUCCESS: return BLE_ERROR_NONE; | ||
| // TODO: map other kind of errors | ||
| // FIXME: the current version of the BlueNRG FW (7.2c) | ||
| // sometimes returns TIMEOUT (0xFF). Ignore the error by now... |
There was a problem hiding this comment.
Could you filter out timeout and handle other cases ?
|
|
||
| private: | ||
| BlueNRGGattClient() { } | ||
|
|
||
| uint8_t gattClientState; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.