Removing SDDriver #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mbed OS now has block device driver code. No need for carrying this as a library. This change will resolve linking errors as seen here ********************************************************************** BUILD/tests/K64F/GCC_ARM/mbed-os/components/storage/blockdevice/COMPONENT_SD/SDBlockDevice.o: In function `mbed::SPI::~SPI()': C:\mbed-cli\ci-test-shield.git/./mbed-os/platform/Callback.h:906: multiple definition of `SDBlockDevice::deinit()' BUILD/tests/K64F/GCC_ARM/SDDriver/features/filesystem/sd/SDBlockDevice.o:C:\mbed-cli\ci-test-shield.git/.\SDDriver\features\filesystem\sd/SDBlockDevice.cpp:260: first defined here BUILD/tests/K64F/GCC_ARM/mbed-os/components/storage/blockdevice/COMPONENT_SD/SDBlockDevice.o: In function `BlockDevice::sync()': *********************************************************************
|
@screamerbg (assuming you're the owner of this repo, wasn't 100% on that) |
|
@c1728p9 Please review |
c1728p9
reviewed
Dec 19, 2018
There was a problem hiding this comment.
@naveenkaje you'll need to add the component 'sd' to mbed_app.json or you'll get build failures on the targets which don't have this component in targets.json.
|
fixed by #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mbed OS now has block device driver code. No need for carrying
this as a library. This change will resolve linking errors
as seen here