Update rollup to v4.18.0 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegecko
reviewed
Jun 4, 2024
rollup.web.config.mjs
Outdated
| const watch = process.env.ROLLUP_WATCH; | ||
|
|
||
| export default { | ||
| input: 'src/index.ts', | ||
| output: [ | ||
| { | ||
| file: pkg.main, |
There was a problem hiding this comment.
Is there any reason this method was removed, its easier to get this directly from package.json rather than maintaining 2 magic strings
There was a problem hiding this comment.
Yes, it's been fixed.
The initial build is much faster than the previous version: 35s -> 5s.
thegecko
reviewed
Jun 5, 2024
| typescript({ | ||
| useTsconfigDeclarationDir: true | ||
| }), | ||
| terser(), | ||
| sourceMaps() |
There was a problem hiding this comment.
Do sourcemaps still appear through another method or is this an oversight removing this?
There was a problem hiding this comment.
No, that's intentional. Rollup looks like generates sourcemap. I can see them in the dist directory.
https://rollupjs.org/configuration-options/#output-sourcemap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This patch involves a major change to rollup, updating it from v2 to v4. The most obvious difference is the build speed, which was reduced from 35s to 5s on my machine when perform initial building.
There are quite a few changes due to the large span of version numbers. Looking forward to your review, thank you.