Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "kvstore" config in the mbed_app.json #80

Closed
wants to merge 1 commit into from
Closed

Update "kvstore" config in the mbed_app.json #80

wants to merge 1 commit into from

Conversation

rajkan01
Copy link

@rajkan01 rajkan01 commented Jul 22, 2020 •
edited
Loading

  • As part of new storage/kvstore directory restructure, we would like to use "kvstore" as config in mbed_lib.json and kept this file in the storage root directory, this will help application to specify one config parameter instead of adding every library like filesystemstore, kv-map, tdbstore, kv-global-api in their mbed_app.json file.
  • Updated "kvstore" config in mbed_app.json to include kvstore library

Reviewers

@SeppoTakalo @michalpasztamobica

@rajkan01 rajkan01 mentioned this pull request Jul 22, 2020
Merged
evedon
evedon suggested changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you introduce the new kvstore library then you should remove the four libraries that were removed in ARMmbed/mbed-os#13307

Alternatively I suggest to re-use kv-global-api, see ARMmbed/mbed-os#13307 (comment)

@rajkan01
Copy link
Author

rajkan01 commented Jul 22, 2020 •
edited
Loading

If you introduce the new kvstore library then you should remove the four libraries that were removed in ARMmbed/mbed-os#13307
Alternatively I suggest to re-use kv-global-api, see ARMmbed/mbed-os#13307 (comment)

@evedon As mentioned in PR ARMmbed/mbed-os#13307, I will proceed with this PR to get reviewed and merged and later I will update the Mbed OS storage config. I have removed four libraries from mbed_app.json.

@rajkan01
Copy link
Author

This issue will be addressed once the new-build tools available

@rajkan01 rajkan01 closed this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evedon evedon evedon requested changes

@SeppoTakalo SeppoTakalo Awaiting requested review from SeppoTakalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajkan01 @evedon