-
Notifications
You must be signed in to change notification settings - Fork 178
New feature: --ignore argument in test.py #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Simply passes the parameter through when building with test.py For more details see ARMmbed/mbed-os#6833
@andrewleech Thanks for this. Looking good to me. @theotherjimmy @cmonr Any concerns? |
@screamerbg @andrewleech We should have the same feature in compile and export, for consistency. |
Would like to poke @sg- for his take on this. |
@andrewleech Note that this won't work prior to Mbed OS 5.9 (after ARMmbed/mbed-os#6833 patch is merged), therefore the option help should explicitly mention this. |
Update help text with minimum mbed-os version (5.9)
Is there a use case for this other than ignoring main when running tests? This certainly is a simple solution but would worry about the annoyance of not remembering what file contains the main function. @bridadan Do you recall the previous thinking around solutions to multiple main functions? |
I've also used it since to build tests with rtos (--exclude main) and then compile app without rtos (--exclude mbed-os/rtos) I guess if you're working completely on the command line this just means more typing. I'm using vscode so the command line is saved in its tools settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the addition.
I believe the option we suggested at the time was to provide a different entry point for tests. Something like One thing to keep in mind with that approach though is that any global static defines in your app's |
Simply passes the parameter through when building with test.py
Supports and requires ARMmbed/mbed-os#6833