Remove a potential call to fwrite with null buffer. Add UBsan testing #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2019
Patater
added
bug
gilles-peskine-arm
requested changes
Sep 3, 2019
AndrzejKurek
force-pushed
the
psa-its-file-fixes
branch
from
19b323e to
9688fc0
Compare
|
Updated the PR. Did not add an additional test to fill in the testing gap after removing MEMORY_BUFFER_ALLOC, since it's bound to be removed anyway here: Mbed-TLS/mbedtls#2469 |
Previously, not all flags were supported by the gcc version that was used (pre-4.9). Now, since the minimum version gcc version tested is 5.4, the flags can be unified.
Enabling MBEDTLS_MEMORY_BUFFER_ALLOC_C bypasses ASan leak checks because system calloc() and free() aren't used.
AndrzejKurek
force-pushed
the
psa-its-file-fixes
branch
from
9688fc0 to
f094b53
Compare
gilles-peskine-arm
approved these changes
Sep 5, 2019
k-stachowiak
approved these changes
Sep 5, 2019
Patater
removed
the
needs: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles issue #203.
First commit removes a potential call to fwrite with a null buffer, and second extends testing.
Tested locally on Ubuntu 16.04 with gcc 5.4 - after extending the testing in CMakeLists and before adding the null check Asan type build fails (and therefore all.sh too). With these two commits - everything passes.
Before merging, this PR will also need a changelog entry to credit nanokatze who has filed this issue.