Skip to content

add initial version of PSA compliance test documents #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 13, 2019

Conversation

NirSonnenschein
Copy link
Contributor

PSA compliance test documents

@NirSonnenschein
Copy link
Contributor Author

documents the addition of test from this PR: ARMmbed/mbed-os#9312

@AnotherButler
Copy link
Contributor

How does this fit into PR #967 ? Our typical porting guide template includes testing information at the bottom of the porting guide. Does this include testing information for all of PSA instead of just attestation? Is that it?

@AnotherButler
Copy link
Contributor

We require engineering review for all new/changed content, so I'm tagging @avolinski for content review.
If he's busy or someone else would be a better fit for this review, please tag a different engineer (who didn't write the PR).

@AnotherButler
Copy link
Contributor

@avolinski @alzix I talked with @NirSonnenschein in our docs reps meeting this morning, and I think this is in the right place. However, our normal porting template usually contains more information. Does either of you know if there's a nontesting porting element to PSA compliance? If so, who will be providing this content?

@alekshex
Copy link
Contributor

alekshex commented Mar 5, 2019

Hi @AnotherButler ,
psa compliance will have in addition an external example repository mainly for OOB.
later when mbedOS will be able to support multiple configurations per build, this repository will become obsolete
https://github.com/ARMmbed/mbed-os-psa-compliance-tests-example

i am not sure if we want to mention it in the documentation
i am not able to access the porting template link in your message it result in 'not found' page
http://docs-previewer.herokuapp.com/documentation_docs/master/writing/mbed-os-vendor-partner-contributing-api-reference.html

@AnotherButler
Copy link
Contributor

I should have mentioned that link only works on the Arm network.

Do you and @ndevillard think a porting guide, if relevant, should wait until Mbed OS can support multiple configurations?

@alekshex
Copy link
Contributor

alekshex commented Mar 5, 2019

Hi @AnotherButler ,
i am on the Arm network, still...
Not Found
The requested resource was not found on this server.

@AnotherButler
Copy link
Contributor

Interesting. That works for me. I'll have to look into it. Here's the GH version: https://github.com/ARMmbed/documentation_docs/blob/master/Docs/Templates/mbed-os-port-template.md

@AnotherButler
Copy link
Contributor

@avolinski or @orenc17 Could one of you please approve this PR if it's ready to merge? We require approval from an engineer who didn't create the PR before we can merge content changes/additions. (Or feel free to tag a different engineer for approval if you're not the right person.)

@GuyWi
Copy link
Contributor

GuyWi commented Mar 11, 2019

@avolinski or @orenc17 , please review and approve this PR.
Thank you!

@NirSonnenschein
Copy link
Contributor Author

@GuyWi thanks the latest exit looks fine to me.
@avolinski thanks for the notes. can you approve the fixes by Guy or do you want anything else?

Make minor edits, mostly for formatting.
@GuyWi
Copy link
Contributor

GuyWi commented Mar 13, 2019

Thanks, @NirSonnenschein !
@avolinski, please approve.

@GuyWi GuyWi merged commit 13b61dc into ARMmbed:development Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants