Skip to content

PSA core 5.12 #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 38 commits into from
Closed

PSA core 5.12 #986

wants to merge 38 commits into from

Conversation

alzix
Copy link
Contributor

@alzix alzix commented Mar 2, 2019

@alzix alzix requested review from AnotherButler and GuyWi March 2, 2019 20:35
Copy link
Contributor

@GuyWi GuyWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my questions/comments.
We should also add examples to the API pages (see, for, instance https://os.mbed.com/docs/mbed-os/v5.11/apis/kvstore.html).

GuyWi added a commit that referenced this pull request Mar 4, 2019
@@ -0,0 +1,11 @@
## Platform service

The Platform service introduces System Reset and PSA Lifecycle APIs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alzix, can you please elaborate on what the platform service is? I see that it consists of the Lifecycle API, which we have documented separately, and the System Reset API. Since Lifecycle is already documented, should we just have a System Reset page? Is there anything else we can say about the system reset? When would you use it? Also, the class reference here is for the Lifecycle API. Can we put the System Reset API class reference instead?

Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some suggestions and queries for y'all to respond to.


### PSA protected storage class reference

[![View code](https://www.mbed.com/embed/?type=library)](../mbed-os-api-doxy/protected__storage_8h.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think the Doxygen transclusions worked with the ../ links. Have you tried this in the preview? If you have and it does, I'll have to start using this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,11 @@
digraph {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file? What does it do?

@@ -0,0 +1,3 @@
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file? What does it do?

@@ -1 +1,3 @@
tags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file? What does it do?

alzix and others added 9 commits March 7, 2019 14:30
@GuyWi GuyWi mentioned this pull request Mar 7, 2019
@alzix
Copy link
Contributor Author

alzix commented Mar 7, 2019

@GuyWi, updated platform service doc

GuyWi added a commit that referenced this pull request Mar 7, 2019
* Docs from "PSA core 5.12 PR #986".

* Update docs.json

* Updated docs.json and file locations.

* Update docs.json

* Removed doxy link.

* Updated links.

* More link fixes.

* Added psa_lifecycle.jpg.

* Delete psa_lifecycle.jpg

* Adding psa_lifecycle.png.

* Updates.

* Adding links from storage to PSA storage.

* Update psa.md

* Update psa_crypto.md

* Update psa_internal_storage.md

* Create testing_psa_service_compliance.md

* Update psa_crypto.md

* Adding PSA porting section.

* Update docs.json

* Updated docs.json.

* Update docs.json

* Update psa_lifecycle.md

* Updated doc.json

* Update psa_attestation.md

* Update psa_attestation.md

* Update psa_attestation.md

* Moved PSA main page to the Security landing page.

* Update porting_psa.md

* Update security.md

* Update security.md

* Update spm.md

* Update storage.md

* Removed empty Example sections in API docs.

* Delete .gitignore

* Delete psa_crypto.md

* Update platform_service.md

* Update docs.json

* Delete porting_psa.md

* Delete testing_psa_service_compliance.md

* Update docs.json

* Update docs.json

* Update platform_service.md
@AnotherButler
Copy link
Contributor

I'm closing this PR because it's been continued in PR #995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants