CMake: install its requirements, not old tools #5
Conversation
|
This fetches the development branch. I don't see any versioning in the script itself, we fetch the latest of everything. What shall we do? |
| @@ -36,7 +36,7 @@ RUN pip3 install -U \ | |||
|
|
|||
| # Set up mbed environment | |||
| WORKDIR /root/ | |||
| RUN wget https://github.com/ARMmbed/mbed-os/raw/master/requirements.txt && \ | |||
| RUN wget https://github.com/ARMmbed/mbed-os/raw/master/tools/cmake/requirements.txt && \ | |||
There was a problem hiding this comment.
| RUN wget https://github.com/ARMmbed/mbed-os/raw/master/tools/cmake/requirements.txt && \ | |
| RUN wget https://github.com/ARMmbed/mbed-os/raw/latest/tools/cmake/requirements.txt && \ |
@0xc0170 @donatieng What do you think? Or is latest not recommended and for backward compatibility of the old tools only?
There was a problem hiding this comment.
I'd recommend matching the version of Mbed OS and the version of the Dockerfile, or at least putting the Mbed OS version into the Dockerfile's version tag/string. So, if a Dockerfile says it works for Mbed OS 7.2.3, the version of requirements.txt it used would have been from version Mbed OS 7.2.3 from Mbed OS.
latest won't work if we want to use this image in CI to test the next release of Mbed OS and Mbed OS's requirements changed since the previous release.
There was a problem hiding this comment.
latest would be an answer to have released version always. But then a question is what tools we should install ? We fetch any the latest (major versions could break the build).
There was a problem hiding this comment.
github.com//pull/6 does also to latest :-)
There was a problem hiding this comment.
I agree with @Patater
I will do that as part of #7 Once done, I will close this PR.
@pan- @donatieng @0xc0170 please shout if that's not alright.
|
What happens if we don't install those? Are they fetched on the first compile (globally, or in a virtualenv)? |
If I do not install tools/cmake/reqs, you get a CMake warning about missing python packages required to be installed. |
Make the build of the mbed os docker image part of mbed-os would solve that. |
It should fix #3