Enable Mbed OS PSA #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDong-Arm
force-pushed
the
mbed_psa_requirement
branch
from
1a00c2d
to
8d8dadc
Compare
|
The compilation is okay with review suggestions in ARMmbed/mbed-os#14652 |
LDong-Arm
force-pushed
the
mbed_psa_requirement
branch
2 times, most recently
from
4e4633c
to
dcfe4c4
Compare
|
Now ready for review |
Patater
reviewed
May 13, 2021
README.md
Outdated
| @@ -9,6 +9,9 @@ The examples in this repository demonstrate how to use the ATECC608A secure elem | |||
|
|
|||
| A target with I2C and power supply connections, connected to an ATECC608A secure element as shown in [Hardware interface](#hardware-interface). | |||
|
|
|||
| Note: This example enables Mbed OS PSA. It is _not_ suitable for or compatible with TF-M which has its own PSA implementations | |||
There was a problem hiding this comment.
- implementations
+ implementationREADME.md: * Document the fact that this example enables Mbed OS PSA which cannot coexist with TF-M. atecc608a/mbed_app/json: * Remove SAML21J18A which is not supported by the latest Mbed OS. * Enable Mbed OS PSA required by the example.
By default, Mbed OS PSA is only enabled on K64F and K66F. This example overrides the configuration to globally enable Mbed OS PSA as needed. We build NRF52_DK in Travis to verify this override. This target was chosen because the pins for atecc608a are already provided in `mbed_app.json`.
LDong-Arm
force-pushed
the
mbed_psa_requirement
branch
from
be6b504
to
a585a4f
Compare
Patater
approved these changes
May 13, 2021
0xc0170
reviewed
May 17, 2021
| @@ -1,18 +1,15 @@ | |||
| { | |||
| "target_overrides": { | |||
| "*": { | |||
| "target.features_add" : ["EXPERIMENTAL_API"], | |||
| "target.features_add" : ["EXPERIMENTAL_API", "PSA"], | |||
| "extra_labels_add": ["MBED_PSA_SRV"], | |||
There was a problem hiding this comment.
[ERROR] Attempt to override undefined parameter 'app.extra_labels_add' in 'application[*]' [mbed] Working path "/builds/workspace/mbed-os-ci_build-example-GCC_ARM/examples/mbed-os-example-atecc608a/atecc608a" (program). This should be target.extra_labels_add
This is from Mbed OS master testing (see the last PR log ARMmbed/mbed-os#14661 (comment)).
There was a problem hiding this comment.
I'm working on this. Somehow even with target missing it works with Mbed CLI 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Mbed OS PSA
README.md:
atecc608a/mbed_app/json:
.travis.yml: