-
Notifications
You must be signed in to change notification settings - Fork 36
Example should now work with SD component #94
Conversation
@yossi2le - SD driver used in bootloader was 5.4 version, and updates on master will increase the code size for bootloader. See ARMmbed/mbed-os#8573 Option:
|
I am closing this PR and open a new one with only the sd-driver.lib changed to point to a new intermediate version of sd-driver repo as @deepikabhavnani proposed. |
@deepikabhavnani the bootloader in this example isn't size optimized so pulling in the newer SD driver shouldn't be a problem. A @yossi2le would it be possible to re-open this PR? |
@c1728p9 - Bootloader is not optimized by latest sd-driver in mbed-os repo is optimized and older version linked to the bootloader was optimized as well. Linking to this will add 1.5K more to the bootloader which needs to be resolved. It will be a problem for devices which have bootloader working (including K64F) |
@deepikabhavnani the bootloader in this example can grow up to 256 KB so the additional 1.5K shouldn't be a problem. |
good to know this.. |
@c1728p9 thanks for your response, It is really good to know that. |
I agree with you on this, the example should be updated to use the sd-driver from Mbed OS instead of deprecated repo. Actually my bad, I should have advised to use the latest sd-driver on first place. Since we have already merged commits to old sd-driver repo, I will leave that to @c1728p9 to decide between this PR or #95 |
To remove the deprecated repo's drop mail to @adbridge. Few storage repositories were deprecated recently and maintainers can decide on plan to archive them all together. |
@deepikabhavnani FWDing deprecation message to @ARMmbed/mbed-os-maintainers |
Description
We are adding get_type to SDBlockDevice and the external sd-driver repo is deprecated. therefore I like to update the example to work with SDBlockDevice component which is part of mebd-os.
Currently, Travis is failing for the mbed-os PR #9135 and PR #9136 and after this change, they should pass.
Pull request type