Skip to content

Work around ARM and IAR optimization issue #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Patater wants to merge 1 commit into from
Closed

Work around ARM and IAR optimization issue #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions getting-started/mbed_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"GCC_ARM": {},
"ARMC6": {
"common": ["-O1"]
},
"ARM": {
"common": ["-O1"]
},
"uARM": {
"common": ["-O1"]
},
"IAR": {
"common": ["-Ol"]
Copy link
Contributor

@dgreen-arm dgreen-arm Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes an error with IAR: [ERROR] Command line error: Option -O can only occur once

Copy link
Contributor Author

@Patater Patater Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, so we need a standalone profile. I am not a fan of maintaining that. I'll see if we can take a better approach.

}
Copy link

@gilles-peskine-arm gilles-peskine-arm Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "GCC_ARM": {} so that we can use the same command line regardless of the target.

(Arguably the fact that mbed compile -t FOO --profile P1 --profile P2 requires FOO to have an entry in both P1 and P2 is a bug in mbed-cli, but we have to work with mbed-cli as it is.)

Copy link
Contributor Author

@Patater Patater Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting the user not to pass the profile option if they didn't need the workaround. I've added all toolchains, since there is at least one user who wanted to use the profile options on non-affected toolchains.

}