Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingletonPtr<Mutex> mutex; in greentea_metrics.cpp conflicts #3292

Closed
Mizuho32 opened this issue Nov 18, 2016 · 2 comments
Closed

SingletonPtr<Mutex> mutex; in greentea_metrics.cpp conflicts #3292

Mizuho32 opened this issue Nov 18, 2016 · 2 comments

Comments

@Mizuho32
Copy link
Contributor

Description

  • Type: Bug(?)
  • Priority: Minor

Bug

Target
Probably all

Toolchain:
GCC_ARM

Toolchain version:
4.9.3 20150529 (prerelease) (15:4.9.3+svn231177-1)

mbed-cli version:
0.9.10

meed-os sha:
a1c0840 Merge pull request #3227 from ARMmbed/release-candidate

This should work.

Mutex mutex;
int main(void){
  return 0;
}

but in actual, it conflicts with below.
greentea_metrics.cpp

/* 37 */ SingletonPtr<Mutex> mutex;

static specifier should be added.

@adbridge
Copy link
Contributor

Hi @Mizuho32 Thanks for finding this and proposing the solution. I believe you are correct .
There are a couple of points to note however.
The first is that the release-candidate branch is for our internal use only and should not be used. Please only take a formal release branch or master for your development.
Secondly all PRs must be made against master and not a release branch. Could you please close your PR #3293 and make it against master? Thanks

@Mizuho32
Copy link
Contributor Author

Oh, sorry for my ignorance.
I'll rise new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants