[STM32] CAN write() return value

[szechyjs]

Description

• Type: Bug
• Related issue: [STM32] CAN read() return value #3463
• Priority: Major

According to the CAN.h header file the write() method is only supposed to return 1 if send was successful. All of the STM32 implementations in can_api.c are hard coded to return 1;.

• STM32F0
• STM32F1
• STM32F2
• STM32F3
• STM32F4
• STM32F7
• STM32L4

The NXP targets implement this correctly, can_api.c

---

Bug

Target
STM32

Expected behavior
Only return 1 if write was successful.

Actual behavior
Returns 1 regardless if write was successful.

Steps to reproduce

if (can1.write(CANMessage(1337, &data, sizeof(data)))
{
    // This will always print
    printf("tx\n");
}

[0xc0170]

cc @bcostm @adustm @LMESTM @jeromecoutant

[adustm]

Hello @0xc0170 @szechyjs
It is not obvious to me that the can_write function is supposed to do some polling as long as the msg is not written.
We are just preparing the sending of the the system and setting the interruptions to be notified when the msg is sent.

Cheers

[adustm]

Hello
What do we do with this issue ? Is it sure that we are supposed to wait ?
I've seen that @Nodraak has created a PR for the read part. Would you be interested into creating a PR for the write part also ?

Cheers

[Nodraak]

Hi !

What is the status here ? It seems that the issue has been fixed by commit 1c4e0d7, as can_write() can sometimes return 0.

[adustm]

Hi,

It seems that the issue has been fixed by commit 1c4e0d7, as can_write() can sometimes return 0.

I think you are right.
@szechyjs could you please check if it fits your need and maybe clode the issue ?

Kind regards

[0xc0170]

I'll close this . Please reopen if any new update