Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M487] Mis-judge as error in mbed-os-tests-mbed_hal-flash #4705

Closed
ccli8 opened this issue Jul 5, 2017 · 5 comments
Closed

[M487] Mis-judge as error in mbed-os-tests-mbed_hal-flash #4705

ccli8 opened this issue Jul 5, 2017 · 5 comments

Comments

@ccli8
Copy link
Contributor

ccli8 commented Jul 5, 2017

Description


Bug

The test case mbed-os-tests-mbed_hal-flash/Flash - clock and cache test is to detect illegal change of cache setting in flash algorithm. It sets up 0.1% performance drift rate to judge illegal change or not. But on NUMAKER_PFM_M487 target, the performance drift rate could reach 5%.

| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash                                                         | Flash - buffer alignment test                                 | 1      | 0      | OK     | 0.12               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash                                                         | Flash - clock and cache test                                  | 0      | 1      | FAIL   | 0.18               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash                                                         | Flash - erase sector                                          | 1      | 0      | OK     | 0.14               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash                                                         | Flash - init                                                  | 1      | 0      | OK     | 0.08               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash                                                         | Flash - mapping alignment                                     | 1      | 0      | OK     | 0.05               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash                                                         | Flash - program page                                          | 1      | 0      | OK     | 0.21               |

Target
NUMAKER_PFM_M487

Toolchain:
ARM|uARM

meed-os sha:
mbed-os-5.5.0

@theotherjimmy
Copy link
Contributor

@ccli8 Why would the performance drift rate reach 5%?

@ccli8
Copy link
Contributor Author

ccli8 commented Jul 10, 2017

Why would the performance drift rate reach 5%?

@theotherjimmy It depends on flash controller in the bottom layer.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2017

Can you elaborate @ccli8 ? We have tested already few variants of flash controllers, haven't experienced this drift. What is causing it? Is this documented anywhere?

cc @c1728p9

@chrissnow
Copy link
Contributor

This may be resolved as #4666 is now merged.

@ccli8
Copy link
Contributor Author

ccli8 commented Jul 14, 2017

@chrissnow Thanks for the fix.

@0xc0170 I check the fix on NUMAKER_PFM_M487 target and the failed test passes now. So the cause is inline, not flash controller.

ARM toolchain

+----------------------+------------------+------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target               | platform_name    | test suite                   | test case                     | passed | failed | result | elapsed_time (sec) |
+----------------------+------------------+------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - buffer alignment test | 1      | 0      | OK     | 0.14               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - clock and cache test  | 1      | 0      | OK     | 0.15               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - erase sector          | 1      | 0      | OK     | 0.11               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - init                  | 1      | 0      | OK     | 0.13               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - mapping alignment     | 1      | 0      | OK     | 0.04               |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - program page          | 1      | 0      | OK     | 0.21               |
+----------------------+------------------+------------------------------+-------------------------------+--------+--------+--------+--------------------+

uARM toolchain

+-----------------------+------------------+------------------------------+-------------------------------+--------+--------+--------+--------------------+
| target                | platform_name    | test suite                   | test case                     | passed | failed | result | elapsed_time (sec) |
+-----------------------+------------------+------------------------------+-------------------------------+--------+--------+--------+--------------------+
| NUMAKER_PFM_M487-uARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - buffer alignment test | 1      | 0      | OK     | 0.14               |
| NUMAKER_PFM_M487-uARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - clock and cache test  | 1      | 0      | OK     | 0.14               |
| NUMAKER_PFM_M487-uARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - erase sector          | 1      | 0      | OK     | 0.13               |
| NUMAKER_PFM_M487-uARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - init                  | 1      | 0      | OK     | 0.14               |
| NUMAKER_PFM_M487-uARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - mapping alignment     | 1      | 0      | OK     | 0.05               |
| NUMAKER_PFM_M487-uARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash | Flash - program page          | 1      | 0      | OK     | 0.22               |
+-----------------------+------------------+------------------------------+-------------------------------+--------+--------+--------+--------------------+

@ccli8 ccli8 closed this as completed Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants