Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtek: REALTEK_RTL8195AM does not have any MCU_ target defined #7690

Closed
0xc0170 opened this issue Aug 3, 2018 · 9 comments
Closed

Realtek: REALTEK_RTL8195AM does not have any MCU_ target defined #7690

0xc0170 opened this issue Aug 3, 2018 · 9 comments

Comments

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 3, 2018

Description

REALTEK_RTL8195AM is a target that defines RTL8195A. If there is a new target that is based on RTL8195A - can't use this target as a base. Because this target contains definitions/code for actual target (PinNames and some other board specific settings). Can we have MCU_RTL8195A that REALTEK_RTL8195AM target would inherit from ?

An example is NRF52_DK that inherits from MCU_NRF52832, see https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L3767

Issue request type

[X] Question
[ ] Enhancement
[ ] Bug

@ARMmbed/team-realtek

@samchuarm
Copy link

samchuarm commented Aug 6, 2018

@ARMmbed/team-realtek @M-ichae-l Can you please help address the question? Thanks
[Mirrored to Jira]

@M-ichae-l
Copy link
Contributor

M-ichae-l commented Aug 6, 2018

@samchuarm
Noted. Thank you.
[Mirrored to Jira]

@M-ichae-l
Copy link
Contributor

M-ichae-l commented Aug 6, 2018

Please refer to #7704 for the changes. MCU_RTL8195A added.
[Mirrored to Jira]

@samchuarm
Copy link

samchuarm commented Sep 26, 2018

Hi @0xc0170 , Realtek submitted separate #7704 to add the support. Can we close this one as it's duplicate? Thanks.
[Mirrored to Jira]

@M-ichae-l
Copy link
Contributor

M-ichae-l commented Sep 26, 2018

Hi, @samchuarm
This PR can be closed and The #8014 block the #7704. #7704 can proceed instantly after #8014 merged.
Many thanks.
[Mirrored to Jira]

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 26, 2018

Please refer to #7704 for the changes. MCU_RTL8195A added.

Let's close this as soon as MCU_ PR gets in!
[Mirrored to Jira]

@adbridge
Copy link
Contributor

adbridge commented Oct 4, 2018

Internal Jira reference: https://jira.arm.com/browse/IOTPART-6060

@samchuarm
Copy link

Can this be closed since #8266 is merged?

@samchuarm
Copy link

Since MCU_target PR is in now, can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants