Adding support for SDP-K1. #10000

malavikasajikumar · 2019-03-07T21:48:02Z

Description

This pull request contains files to support SDP-K1 board on Mbed. This board uses STM32F469NI Cortex-M4 processor.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

ciarmcom · 2019-03-07T22:00:40Z

@malavikasajikumar, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

ghost · 2019-03-07T22:37:42Z

Conditionally Approved for 5.12 - if risk is low and no side effects to other targets, this is approved.
(Also congrats on # 10,000)

cmonr · 2019-03-08T00:58:51Z

@malavikasajikumar Please update the description.

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F469xI/TARGET_SDP-K1/system_clock.c

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F469xI/TARGET_SDP-K1/PinNames.h

0xc0170 · 2019-03-08T06:02:28Z

Adding support for SDP-K1. #10000

💯x💯 👍 🎉 🍾

@cmonr What description should be updated?

entire PR template - PR description and PR type - provide information about what are you introducing

bulislaw

Please remove the dead (commented out) code and provide test results for all 3 compilers.

targets/targets.json

0xc0170 · 2019-03-08T09:58:47Z

New target needs pasting test logs for all 3 toolchains, please attach them to the pull request

Besides these minor comments, LGTM

malavikasajikumar · 2019-03-08T19:22:19Z

What is causing this CI test failure?
https://travis-ci.org/ARMmbed/mbed-os/jobs/503729968

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F469xI/TARGET_SDP-K1/system_clock.c

Fixing a few more alignment issues.

malavikasajikumar · 2019-03-11T19:08:06Z

@cmonr @0xc0170 @bulislaw

Test log files for GCC_ARM. Separately attached the log file for mbed-os-tests-mbedmicro-rtos-mbed-mutex timeout.

SDP-K1_GCC-ARM.log
SDP-K1_GCC-ARM_rtos-mbed-mutex.log

Test log files

SDP-K1_ARM.log
SDP-K1_ARM_mbed_platform-stream.log
SDP-K1_ARM_mbed_platform-critical_section.log

malavikasajikumar · 2019-03-11T20:42:25Z

Moved back for RC2 to make sure this isn't lost.

If it can pass testing in time, it can make it into RC2. Otherwise, we can look at a branch or other alternatives.

CC @bentcooke

Test log files uploaded.

cmonr · 2019-03-12T03:32:33Z

CI started

mbed-ci · 2019-03-12T05:01:06Z

Test run: FAILED

Summary: 3 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_build-ARMC6

0xc0170 · 2019-03-12T07:34:32Z

targets/targets.json

@@ -3694,6 +3694,42 @@
 "device_name": "STM32F469NI",
 "bootloader_supported": true
 },
+ "SDP-K1": {


SDP_K1 should be the name (as any other target). The failure in the build might be related (as it cant find the target) - this could be a bug in our tools or rather unsupported feature

cc @ARMmbed/mbed-os-tools

Would that be a cause of CI test failures? The name with hyphen is consistent across all the supporting files. @bentcooke

I believe yes. You should be able to reproduce the build failure locally. To be consistent, it should use _ instead. (review any other targets). This follows also directory naming TARGET_ and others.

@0xc0170 @bentcooke Fixed the hyphen to underscore, ran the tests on IAR toolchain.

0xc0170 · 2019-03-12T07:35:19Z

Moving back to 5.12.1, 5.12.0-rc2 is now ready and going to be released

malavikasajikumar · 2019-03-12T07:39:14Z

Moving back to 5.12.1, 5.12.0-rc2 is now ready and going to be released

Guess we will have to go with a separate branch then, that can be imported into mbed compiler. @cmonr

theotherjimmy · 2019-03-12T14:24:31Z

@malavikasajikumar Please don't use another branch (it would have to be a fork, FYI) to import into the online compiler. Mbed OS is cached and this strategy skips the cache and costs ARM GB of storage for every import.

malavikasajikumar · 2019-03-20T18:49:00Z

Fixed the issues. Attached are the test log files. @0xc0170 @bulislaw @ashok-rao @bentcooke Could you approve the changes?

SDP_K1_ARM_test.log

SDP_K1_IAR_test.log
SDP_K1_IAR_test_TIMEOUTS.log

SDP_K1_GCC_ARM_test.log
SDP_K1_GCC_ARM_test_TIMEOUTS.log

bulislaw · 2019-03-22T11:35:48Z

We can't merge the platform support with failing tests. Can you please debug it to get to the bottom of the issues?

malavikasajikumar · 2019-03-22T16:49:53Z

We can't merge the platform support with failing tests. Can you please debug it to get to the bottom of the issues?

The tests that timed out were run again and were successful. The second log files (SDP_K1_IAR_test_TIMEOUTS.log and SDP_K1_GCC_ARM_test_TIMEOUTS.log) shows these tests succeeding. Could you confirm? @bulislaw

malavikasajikumar · 2019-03-22T20:03:14Z

Thank you for the approval. @bulislaw

@ashok-rao @0xc0170 Please let us know if there are anymore changes/updates needed.

cmonr · 2019-03-26T03:01:56Z

CI started

mbed-ci · 2019-03-26T07:06:16Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

Changes addressed

Adding support for SDP-K1.

malavikasajikumar · 2019-03-27T15:43:30Z

Thank you! @cmonr @bentcooke @0xc0170 @bulislaw

Adding support for SDP-K1.

2ffa39f

ciarmcom requested review from screamerbg and a team March 7, 2019 22:00

ciarmcom added the needs: review label Mar 7, 2019

cmonr added do not merge and removed do not merge labels Mar 8, 2019

cmonr requested a review from a team March 8, 2019 00:58

cmonr added needs: work release-version: 5.12.0-rc2 and removed needs: review labels Mar 8, 2019

0xc0170 requested changes Mar 8, 2019

View reviewed changes

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F469xI/TARGET_SDP-K1/system_clock.c Outdated Show resolved Hide resolved

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F469xI/TARGET_SDP-K1/PinNames.h Outdated Show resolved Hide resolved

jeromecoutant approved these changes Mar 8, 2019

View reviewed changes

bulislaw suggested changes Mar 8, 2019

View reviewed changes

0xc0170 reviewed Mar 8, 2019

View reviewed changes

targets/targets.json Outdated Show resolved Hide resolved

0xc0170 reviewed Mar 8, 2019

View reviewed changes

targets/targets.json Outdated Show resolved Hide resolved

0xc0170 requested a review from ashok-rao March 8, 2019 09:58

0xc0170 added the scope: new-target label Mar 8, 2019

malavikasajikumar added 5 commits March 8, 2019 08:48

Fixing alignment on the lines for SDP-K1 description.

a8fc16e

Removing commented out lines. Added SDP connector pins.

5e9e140

Adding SPDX identifier (year 2019) to the license.

b8d4ad2

Fixing for Travis CI test fail. 5e9e140.

d4cc30c

Adding support for SDP connector pins.

481c19e

screamerbg approved these changes Mar 8, 2019

View reviewed changes

0xc0170 reviewed Mar 8, 2019

View reviewed changes

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F469xI/TARGET_SDP-K1/system_clock.c Outdated Show resolved Hide resolved

Disabling LPTICKER for now.

aef1cb6

Fixing a few more alignment issues.

0xc0170 previously requested changes Mar 12, 2019

View reviewed changes

0xc0170 added release-version: 5.12.1 and removed release-version: 5.12.0-rc2 labels Mar 12, 2019

Renaming SDP-K1 to SDP_K1.

00863c2

bulislaw approved these changes Mar 22, 2019

View reviewed changes

cmonr added needs: review and removed needs: work labels Mar 26, 2019

cmonr requested a review from 0xc0170 March 26, 2019 16:29

cmonr added ready for merge and removed needs: review labels Mar 26, 2019

cmonr approved these changes Mar 26, 2019

View reviewed changes

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10000 from malavikasajikumar/master

17d6e29

Adding support for SDP-K1.

cmonr merged commit b872d08 into ARMmbed:master Mar 27, 2019

cmonr removed the ready for merge label Mar 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support for SDP-K1. #10000

Adding support for SDP-K1. #10000

malavikasajikumar commented Mar 7, 2019 •

edited

Loading

ciarmcom commented Mar 7, 2019

ghost commented Mar 7, 2019

cmonr commented Mar 8, 2019

0xc0170 commented Mar 8, 2019

bulislaw left a comment

0xc0170 commented Mar 8, 2019

malavikasajikumar commented Mar 8, 2019

malavikasajikumar commented Mar 11, 2019 •

edited

Loading

malavikasajikumar commented Mar 11, 2019

cmonr commented Mar 12, 2019

mbed-ci commented Mar 12, 2019

0xc0170 Mar 12, 2019

malavikasajikumar Mar 12, 2019 •

edited

Loading

0xc0170 Mar 12, 2019

malavikasajikumar Mar 15, 2019 •

edited

Loading

0xc0170 commented Mar 12, 2019

malavikasajikumar commented Mar 12, 2019

theotherjimmy commented Mar 12, 2019

malavikasajikumar commented Mar 20, 2019

bulislaw commented Mar 22, 2019

malavikasajikumar commented Mar 22, 2019 •

edited

Loading

malavikasajikumar commented Mar 22, 2019

cmonr commented Mar 26, 2019

mbed-ci commented Mar 26, 2019

malavikasajikumar commented Mar 27, 2019

Adding support for SDP-K1. #10000

Adding support for SDP-K1. #10000

Conversation

malavikasajikumar commented Mar 7, 2019 • edited Loading

Description

Pull request type

Reviewers

Release Notes

ciarmcom commented Mar 7, 2019

ghost commented Mar 7, 2019

cmonr commented Mar 8, 2019

0xc0170 commented Mar 8, 2019

bulislaw left a comment

Choose a reason for hiding this comment

0xc0170 commented Mar 8, 2019

malavikasajikumar commented Mar 8, 2019

malavikasajikumar commented Mar 11, 2019 • edited Loading

malavikasajikumar commented Mar 11, 2019

cmonr commented Mar 12, 2019

mbed-ci commented Mar 12, 2019

Test run: FAILED

0xc0170 Mar 12, 2019

Choose a reason for hiding this comment

malavikasajikumar Mar 12, 2019 • edited Loading

Choose a reason for hiding this comment

0xc0170 Mar 12, 2019

Choose a reason for hiding this comment

malavikasajikumar Mar 15, 2019 • edited Loading

Choose a reason for hiding this comment

0xc0170 commented Mar 12, 2019

malavikasajikumar commented Mar 12, 2019

theotherjimmy commented Mar 12, 2019

malavikasajikumar commented Mar 20, 2019

bulislaw commented Mar 22, 2019

malavikasajikumar commented Mar 22, 2019 • edited Loading

malavikasajikumar commented Mar 22, 2019

cmonr commented Mar 26, 2019

mbed-ci commented Mar 26, 2019

Test run: SUCCESS

malavikasajikumar commented Mar 27, 2019

malavikasajikumar commented Mar 7, 2019 •

edited

Loading

malavikasajikumar commented Mar 11, 2019 •

edited

Loading

malavikasajikumar Mar 12, 2019 •

edited

Loading

malavikasajikumar Mar 15, 2019 •

edited

Loading

malavikasajikumar commented Mar 22, 2019 •

edited

Loading