Selectively append changes to exported config files #10118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of a non-overwriting change to an exported config file the previous logic appended a new block of text to the previous file every time the to-be-written block of text was not exactly matched. This parses the old config file and the to-be-written changes into sets, which can then be compared. If all of the incoming lines are found in the old config file set, no changes are made. If some incoming lines are not found in the old config file, only these are appended.
|
@arskanov, thank you for your changes. |
theotherjimmy
approved these changes
Mar 15, 2019
cmonr
approved these changes
Mar 15, 2019
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 16, 2019
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 16, 2019
Selectively append changes to exported config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For #10117
In case of a non-overwriting change to an exported config file
the previous logic appended a new block of text to the previous file
every time the to-be-written block of text was not exactly matched.
This parses the old config file and the to-be-written changes into
sets, which can then be compared. If all of the incoming lines are
found in the old config file set, no changes are made. If some
incoming lines are not found in the old config file, only these are
appended.
Pull request type
Reviewers
Release Notes
Not tested on windows or python 2.
Uses .splitlines(), and newlines should be correctly handled by the file read and write functions.