-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cellular: Power ON Wait Increased for C030_U201 #10229
Conversation
@mudassar-ublox, thank you for your changes. |
This change feels like the wrong thing to do. Why does the single target need more time to wait? |
@cmonr |
@fahim-ublox & @RobMeades |
@cmonr: could also just make it 10 seconds for all case, to remove the conditional, it wouldn't do any harm. |
@RobMeades @mudassar-ublox I think I'd prefer that solution instead. |
@AriParkkila Thoughts one way or another? |
@cmonr I think the proposed change is fine, however :) It seems that cellular testing will be replaced by the generic Mbed OS netsocket and network-interface tests:
|
@AriParkkila Not sure I follow your last comment. Could you elaborate? |
@cmonr it's fine to add 10 seconds in all cases. However, I probably wouldn't use very much effort on cellular specific Greentea tests anymore due to the generic Mbed OS TESTS for network-interface and netsocket have much better test coverage are now good for cellular testing too. |
Aaah, gotcha. This was the part I wasn't clear on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woudl refer a blanket increase in wait time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer a banket wait time.
@mudassar-ublox If you could update the change to simply be blanket wait time increase, I can approve and get CI started on this. |
@cmonr pull request is updated. Please review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, increase fix like this should contain a reason for increase in the commit msg (why are we changing this from 5 to 10).
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Description
Increased wait for power up of module in
CellularDevice
test case, as UBLOX_C030_U201 took 10-12 sec to power up.Pull request type
Reviewers
Release Notes