Nanostack::EthernetInterface::bringdown() can handle blocking mode #10243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This let the tests-network-interface test pass for nanostack.
|
@michalpasztamobica, thank you for your changes. |
cmonr
reviewed
Mar 27, 2019
| return NSAPI_ERROR_DEVICE_ERROR; | ||
| } | ||
|
|
||
| if (_blocking) { | ||
| int32_t count = disconnect_semaphore.wait(30000); |
There was a problem hiding this comment.
I took it from the bringup procedure... Is there a specified timeout that you'd suggest?
cmonr
approved these changes
Mar 27, 2019
VeijoPesonen
approved these changes
Mar 28, 2019
SeppoTakalo
approved these changes
Mar 28, 2019
|
Why this is marked as a functionality change? We are not changing the API, and we are making it to pass tests that existed before, and are documented. Therefore it is a fix, and can be published in patch release as well. |
cmonr
added
needs: CI
release-version: 5.12.1
and removed
needs: review
release-version: 5.13.0-rc1
labels
|
Rechecked the code changes. I was wondering the same thing, but figured y'all knew something I didn't 😁 Updated to a patch release. |
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This let the tests-network-interface test suite pass for nanostack.
Pull request type
Reviewers
@SeppoTakalo