Fix detection of supported targets for mbed 2 builds #10347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bridadan, thank you for your changes. |
theotherjimmy
approved these changes
Apr 8, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 9 test jobs failed Failed test jobs:
|
|
Looking at the build failures, only SAM targets failed Mbed 2 ARMC5 build. Please review |
0xc0170
approved these changes
Apr 9, 2019
|
Looks like those targets aren't compatible with ARMC6, so I moved them to ARMC5 only. |
|
CI started |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
The hal code for this target uses "const volatile" types inside of structs, which are non-trivially copyable in clang (used by ARMC6). This causes the build to fail. Here's the commit that changed this in clang: llvm-mirror/clang@a3d727b It seems this was reverteed some time ago in clang, but ARMC6 may not be up to date.
bridadan
force-pushed
the
allow_mbed_2_builds
branch
from
ec49777
to
11775ef
Compare
|
Oh jeez, I missed one. Pushed a fix. |
rabble rabble rabble |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
@jeromecoutant Mind taking a look at this? |
jeromecoutant
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #10107.
This should get Mbed 2 builds going again with ARMC6. The uARM logic doesn't seem to be 100%, but honestly I'm not really sure what the expected behavior is for it.
Pull request type
Reviewers
Release Notes
@jeromecoutant