Cellular: Using new rather than malloc in debug_print #10354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using malloc will require us to add stdlib.h somewhere in the path for the application. Maybe the CI apps are adding stdlib.h and that's why the code would have worked. In a custom app, it can happen that the header is not included. Using new avoids the need to add stdlib.h anywhere and it is more in line with C++.
hasnainvirk
changed the title
|
@wajahat-ublox Please review. |
kivaisan
approved these changes
Apr 9, 2019
|
Looks good to me, thank you for this quick fix. |
wajahat-abbas
approved these changes
Apr 9, 2019
0xc0170
approved these changes
Apr 9, 2019
0xc0170
changed the title
|
Ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
AnttiKauppila
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using malloc will require us to add stdlib.h somewhere in the path for
the application. Maybe the CI apps are adding stdlib.h and that's why
the code would have worked. In a custom app, it can happen that the
header is not included. Using new avoids the need to add stdlib.h
anywhere and it is more in line with C++.
Fixes the issue defined here #10352
Pull request type
Reviewers
@kivaisan @AnttiKauppila @0xc0170
Release Notes