Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings on PSA secure builds #10407

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Fix warnings on PSA secure builds #10407

merged 1 commit into from
Apr 18, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Apr 15, 2019 •
edited
Loading

Description

  • Add #include where needed
  • Cast where needed
  • Remove #include psa/service.h from NSPE in PSA tests

Fix most of the warnings from #10396

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170 and a team April 15, 2019 17:00
@ciarmcom
Copy link
Member

@orenc17, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 17, 2019

Failures related, please fix

@orenc17
Copy link
Contributor Author

orenc17 commented Apr 17, 2019

Fixed and rebased

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 17, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 merged commit ca887a9 into ARMmbed:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orenc17 @ciarmcom @0xc0170 @mbed-ci