Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFM: Fix compile error with casting #10439

Closed

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 18, 2019

Description

This PR fixes compile error on casting void * to sfn_t implicitly in TFM code.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2019

@ARMmbed/mbed-os-psa This comes from external sources? Is it fixed there ?

@ciarmcom ciarmcom requested a review from a team April 18, 2019 09:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@orenc17
Copy link
Contributor

orenc17 commented Apr 18, 2019

@0xc0170
TFM source code is imported periodically, we do not accept PR changing specific code

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2019

In this case, if this is a build error, @orenc17 how to check this is fixed there and when we can fetch the update?

@orenc17
Copy link
Contributor

orenc17 commented Apr 18, 2019

we merged #10286 a week ago, which updated the TFM sources
if @ccli8 can provide a TFM hash that solves the issue i could try to do another import

BTW iwe should have seen an error on other TFM platforms

@0xc0170 0xc0170 requested a review from a team April 18, 2019 09:14
@ccli8
Copy link
Contributor Author

ccli8 commented Apr 18, 2019

@orenc17 To reproduce the issue of #10439, follow the steps:

  1. Clone the secure build project (mbed-os version must match)
  2. Apply PSA: Pass TFM_LVL macro to linker files #10438 first
  3. Build with mbed compile -m NUMAKER_PFM_M2351_S -t ARMC6 --app-conf mbed_app.json, and you should see error message with TFM: Fix compile error with casting #10439.

@orenc17
Copy link
Contributor

orenc17 commented Apr 18, 2019

@ccli8
i would suggest adding your secure target to mbed-os like the LPC55S69_S target instead of creating a separate repo

@ccli8
Copy link
Contributor Author

ccli8 commented Apr 18, 2019

@orenc17 Secure target like NUMAKER_PFM_M2351_S has added into target.json. The separate repo is for configurable from outside.

@orenc17
Copy link
Contributor

orenc17 commented Apr 18, 2019

@ccli8 as i said before i cannot allow this change due to the nature of how we maintain TF-M sources in the mbed-os tree.
i could suggest creating a change request in TF-M gerrit

once that change is merged i could import it

@ccli8
Copy link
Contributor Author

ccli8 commented Apr 19, 2019

@orenc17 That's fine. Thanks.

@adbridge
Copy link
Contributor

@orenc17 should this PR be closed then ?

@orenc17
Copy link
Contributor

orenc17 commented Apr 25, 2019

Yes

@0xc0170 0xc0170 closed this Apr 29, 2019
@ccli8
Copy link
Contributor Author

ccli8 commented Jun 3, 2019

Merged into TF-M repo.

@cyliangtw cyliangtw deleted the nuvoton_psa_fix_tfm_compile branch March 9, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants