Enterprise_mode_+_wifi_configuraiton_api: update ODIN drivers to v3.7.0 RC1 #10454

aqib-ublox · 2019-04-23T06:40:58Z

Description

This pull requests contains

Enterprise mode supporting EAP_TLS and PEAP methods for enterprise security.
A new private API for wifi connect() as enterprise mode require certificates such as CA server and client certificate along with private key in addition to credentials for connection.
Wifi configuration API.

This release also contains following fixes

Ublox: Ublox Odin W2 WIFI asserts during firmware download #9621
UBLOX_EVK_ODIN_W2 with IAR returns DEVICE_ERROR instead of AUTH_ERROR/NO_CONNECTION when wrong channel is set #10312

Tests Results

iar_mbed_os_log.txt
arm_mbed_os_logs.txt
gcc_arm_mbed_os_log.txt
arm_driver_log.txt
iar_driver_logs.txt
gcc_arm_driver_logs.txt
iar_ble_gatt_server.txt
gcc_arm_ble_gatt_server.txt
arm_ble_gatt_server.txt

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

A private API is provided for ODIN_W2 target against enterprise mode.

    nsapi_error_t connect(
        const char          *ssid,
        const char          *pass,
        nsapi_security_t  security,
        auth_cert_s         *cert_handle,
        const char          *username = NULL,
        const char          *user_pswd = NULL,
        uint8_t               channel = 0);

Application is required to pass certificate(CA cert or client cert) and key (private key) in PEM format currently. User is required to pass those certificates through cert_handle auth_cert_s and an appropriate security should be selected either NSAPI_SECURITY_EAP_TLS or NSAPI_SECURITY_PEAP.

For example:

static auth_cert_s   certificates;
_wifi = new OdinWiFiInterface(true);
#ifdef EAP_TLS_TESTING
    certificates.client_cert = &cert_data[0];
    certificates.client_prvt_key = &cert_data_key[0];
    certificates.ca_cert = NULL;
#elif defined(PEAP_TESTING)
    certificates.client_cert = NULL;
    certificates.client_prvt_key = NULL;
    certificates.ca_cert = &ca_cert_data[0];
#endif
_wifi->connect(ssid, pass, security, &certificates, _peap_username, _peap_user_pass, channel);

NOTE:
security could be NSAPI_SECURITY_EAP_TLS or NSAPI_SECURITY_PEAP

Configuration API

    virtual unsigned int get_config(void *setting);
    virtual void set_config(void *setting, cb_uint32 value);

description of parameters available in
https://github.com/u-blox/mbed-os/blob/0dda8c447c644cb8ee5063099ad09226a6caf746/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/cb_wlan_driver_config.h

features/netsocket/nsapi_types.h

...TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/OdinWiFiInterface.h

...RGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/OdinWiFiInterface.cpp

aqib-ublox · 2019-04-25T05:46:54Z

@MarceloSalazar can u ask ur team to start review as we need to target it in coming release i-e 12.2 most likely

ciarmcom · 2019-04-25T11:09:33Z

@aqib-ublox, thank you for your changes.
@ARMmbed/mbed-os-tls @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

adbridge · 2019-04-25T15:05:39Z

@michalpasztamobica could you re-review please ?

michalpasztamobica

I still think NSAPI_ERROR_CERT_SIZE is not necessary and NSAPI_ERROR_PARAMETER should be used instead.
@SeppoTakalo , what do you think?

aqib-ublox · 2019-04-29T09:46:14Z

@SeppoTakalo what u suggest?

SeppoTakalo · 2019-04-29T09:48:04Z

@SeppoTakalo what u suggest?

Use NSAPI_ERROR_PARAMETER so you are then not causing any changes to public Mbed OS APIs.

aqib-ublox · 2019-04-29T10:18:18Z

@SeppoTakalo what u suggest?

Use NSAPI_ERROR_PARAMETER so you are then not causing any changes to public Mbed OS APIs.

it's removed and replaced with NSAPI_ERROR_PARAMETER

aqib-ublox · 2019-04-30T12:48:01Z

@MarceloSalazar waiting for review to be finalised?

MarceloSalazar · 2019-04-30T12:58:28Z

@ARMmbed/mbed-os-maintainers please review

0xc0170

The main concern is about tls config change, requested help from tls team.

features/mbedtls/inc/mbedtls/config.h

0xc0170 · 2019-04-30T13:27:41Z

...STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/UbloxWiFiConfigInterface.h

@@ -0,0 +1,52 @@
+/* ODIN-W2 implementation of WiFi Config Interface
+ * Copyright (c) 2016 u-blox Malm� AB


year should be 2019

Add please SPDX identifier as well

also here, SPDX identifier

already there LICENSE-2.0 ?

SPDX-License-Identifier: Apache-2.0 is needed, as in other files

0xc0170 · 2019-04-30T13:28:03Z

...2F4/TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/odin_drv_conf.h

@@ -0,0 +1,117 @@
+/* ODIN-W2 user Config Interface
+ * Copyright (c) 2016 u-blox Malm� AB
+ *


also here, SPDX identifier

@0xc0170 corrected

0xc0170 · 2019-04-30T13:30:16Z

Functionality change

Only in targets code - can go to the patch release ? I see above note about 5.12.2 .

aqib-ublox · 2019-05-02T04:56:41Z

Functionality change

Only in targets code - can go to the patch release ? I see above note about 5.12.2 .

@0xc0170 couldn't get it? 5.12.2 is released so might be target in next patch release or u prefer it to be part of full release? in that case as per @MarceloSalazar code freeze for that is 30 May and that's too far. Please correct me if i am wrong

0xc0170 · 2019-05-02T07:59:21Z

Edited: this is extending security type, therefore it was as "functionality change". In this case, 5.13 would be appropriate.

@RonEld If you can help how to resolve that mbed config - it is the main outstanding one in this PR.

features/netsocket/nsapi_types.h

0xc0170

Waiting for mbedtls config change

features/mbedtls/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/mbedtls_device.h

aqib-ublox · 2019-05-05T18:06:38Z

@0xc0170 and @RonEld can u please acknowledge recent changset

aqib-ublox · 2019-05-07T05:44:13Z

@0xc0170, @RonEld any update?

RonEld

LGTM
The configuration for MBEDTLS_MPI_WINDOW_SIZE should be documented though, in case your users would like to change it in their user defined configuration.

aqib-ublox · 2019-05-08T07:18:53Z

@0xc0170 ?

MarceloSalazar · 2019-05-08T11:14:27Z

@ARMmbed/mbed-os-maintainers please review and comment.
If possible, we'd like this to be released in the next patch release.

k-stachowiak

I left a question regarding a curious construct; otherwise I did not find any Mbed TLS related issues.

k-stachowiak · 2019-05-07T15:18:02Z

...RGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/OdinWiFiInterface.cpp

+	case ODIN_CFG_SET_FT_MODE:                              return cbTARGET_CFG_SET_FT_MODE;
+	case ODIN_CFG_GET_FT_MODE:                              return cbTARGET_CFG_GET_FT_MODE;
+    default:
+        MBED_ASSERT(true);


Is this supposed to be asserting true? It would seem more natural to assert false upon encountering an unrecognized identifier.

Edit: there is one more such case.

Yes that's right @AmmadRehmat please see this

@k-stachowiak it's corrected thanks for pointing out

aqib-ublox · 2019-05-08T12:56:40Z

...RGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/OdinWiFiInterface.cpp

+	case ODIN_CFG_SET_FT_MODE:                              return cbTARGET_CFG_SET_FT_MODE;
+	case ODIN_CFG_GET_FT_MODE:                              return cbTARGET_CFG_GET_FT_MODE;
+    default:
+        MBED_ASSERT(false);


@k-stachowiak corrected

aqib-ublox · 2019-05-08T12:56:48Z

...RGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/OdinWiFiInterface.cpp

+    case ODIN_POWER_SAVE_MODE_DEEP_SLEEP:   return cbTARGET_POWER_SAVE_MODE_DEEP_SLEEP;
+        default:
+            MBED_ASSERT(false);
+    }


@k-stachowiak corrected

aqib-ublox · 2019-05-09T10:05:48Z

@0xc0170 any update?

aqib-ublox · 2019-05-14T06:28:42Z

@0xc0170 ?

aqib-ublox · 2019-05-17T04:27:39Z

@MarceloSalazar whats status?

adbridge · 2019-05-17T09:22:27Z

@0xc0170 please confirm you are happy with the licence updates. Running the CI in the meantime

mbed-ci · 2019-05-17T13:22:21Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

terrier1-github · 2022-02-21T10:55:21Z

Hello, I'm working on IoT project and I want to use WiFi enterprise protocole (eap-tls) to connect my device, I recovered a EKV-ODIN-W2 board, but regarding the software part I don't know how to start, is it possible to recover a getting started for Enterprise mode for ODIN-W2 ?

JanneKiiskila · 2022-02-21T10:58:38Z

@aqib-ublox @adbridge @0xc0170 to comment.

0xc0170 · 2022-02-21T16:03:08Z

cc @ARMmbed/team-ublox if anyone can help with the above question

aqib-ublox mentioned this pull request Apr 23, 2019

Ublox: Ublox Odin W2 WIFI asserts during firmware download #9621

Closed

michalpasztamobica reviewed Apr 23, 2019

View reviewed changes

features/netsocket/nsapi_types.h Outdated Show resolved Hide resolved

michalpasztamobica reviewed Apr 23, 2019

View reviewed changes

...TARGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/OdinWiFiInterface.h Outdated Show resolved Hide resolved

michalpasztamobica suggested changes Apr 23, 2019

View reviewed changes

...RGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/OdinWiFiInterface.cpp Show resolved Hide resolved

aqib-ublox force-pushed the ublox_odin_driver_os_5_v3.7.0_rc1 branch from 0dda8c4 to c98c35e Compare April 23, 2019 10:26

ciarmcom requested review from a team April 25, 2019 11:09

ciarmcom added the needs: review label Apr 25, 2019

michalpasztamobica suggested changes Apr 26, 2019

View reviewed changes

aqib-ublox force-pushed the ublox_odin_driver_os_5_v3.7.0_rc1 branch from c98c35e to 3eb8248 Compare April 29, 2019 10:13

SeppoTakalo approved these changes Apr 29, 2019

View reviewed changes

michalpasztamobica approved these changes Apr 29, 2019

View reviewed changes

0xc0170 requested changes Apr 30, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Apr 30, 2019

0xc0170 reviewed May 2, 2019

View reviewed changes

features/netsocket/nsapi_types.h Show resolved Hide resolved

0xc0170 added the release-version: 5.13.0-rc1 label May 2, 2019

0xc0170 requested changes May 2, 2019

View reviewed changes

aqib-ublox force-pushed the ublox_odin_driver_os_5_v3.7.0_rc1 branch from 3c1a2c2 to 0282f1e Compare May 3, 2019 11:31

aqib-ublox commented May 3, 2019

View reviewed changes

features/mbedtls/targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/mbedtls_device.h Show resolved Hide resolved

RonEld approved these changes May 7, 2019

View reviewed changes

k-stachowiak reviewed May 8, 2019

View reviewed changes

Enterprise mode + wifi configuraiton api

43759c0

aqib-ublox force-pushed the ublox_odin_driver_os_5_v3.7.0_rc1 branch from 0282f1e to 43759c0 Compare May 8, 2019 12:55

aqib-ublox commented May 8, 2019

View reviewed changes

k-stachowiak approved these changes May 8, 2019

View reviewed changes

adbridge added needs: CI and removed needs: work labels May 17, 2019

0xc0170 approved these changes May 20, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels May 20, 2019

0xc0170 merged commit d4122b0 into ARMmbed:master May 20, 2019

0xc0170 removed the ready for merge label May 21, 2019

aqib-ublox mentioned this pull request May 28, 2019

UBLOX_EVK_ODIN_W2 wifi connection breaks after a few minutes #9071

Closed

		@@ -0,0 +1,52 @@
		/* ODIN-W2 implementation of WiFi Config Interface
		* Copyright (c) 2016 u-blox Malm� AB

Enterprise_mode_+_wifi_configuraiton_api: update ODIN drivers to v3.7.0 RC1 #10454

Enterprise_mode_+_wifi_configuraiton_api: update ODIN drivers to v3.7.0 RC1 #10454

Uh oh!

Conversation

aqib-ublox commented Apr 23, 2019 • edited by 0xc0170 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aqib-ublox commented Apr 25, 2019

Uh oh!

ciarmcom commented Apr 25, 2019

Uh oh!

adbridge commented Apr 25, 2019

Uh oh!

michalpasztamobica left a comment

Choose a reason for hiding this comment

Uh oh!

aqib-ublox commented Apr 29, 2019

Uh oh!

SeppoTakalo commented Apr 29, 2019

Uh oh!

aqib-ublox commented Apr 29, 2019

Uh oh!

aqib-ublox commented Apr 30, 2019

Uh oh!

MarceloSalazar commented Apr 30, 2019

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Apr 30, 2019

Uh oh!

aqib-ublox commented May 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented May 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aqib-ublox commented May 5, 2019

Uh oh!

aqib-ublox commented May 7, 2019

Uh oh!

RonEld left a comment

Choose a reason for hiding this comment

Uh oh!

aqib-ublox commented May 8, 2019

Uh oh!

MarceloSalazar commented May 8, 2019

Uh oh!

k-stachowiak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aqib-ublox commented Apr 23, 2019 •

edited by 0xc0170

Loading

aqib-ublox commented May 2, 2019 •

edited

Loading

0xc0170 commented May 2, 2019 •

edited

Loading