Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new features to Toshiba's TMPM4G9 #10633

Merged
merged 5 commits into from Jul 5, 2019
Merged

Add new features to Toshiba's TMPM4G9 #10633

merged 5 commits into from Jul 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 22, 2019

Description

Add new features to Toshiba's TMPM4G9

  • SPISlave
  • SERIAL_FC
  • SPI_ASYNCH
  • I2C_ASYNCH
  • RTC

Tested with all 3 toolchains and attached test logs:
M4G9_ARM_TestResults.txt
M4G9_GCC_ARM_TestResults.txt
M4G9_IAR_TestResults.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested a review from a team May 22, 2019 13:00
@ciarmcom
Copy link
Member

@ganesh-ramachandran, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 requested changes May 23, 2019
View reviewed changes
targets/targets.json Outdated Show resolved Hide resolved
targets/TARGET_TOSHIBA/TARGET_TMPM4G9/rtc_api.c Show resolved Hide resolved
@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

@ganesh-ramachandran How we can fix ARMC5 ? It is not supported anymore, should not be used for new targets. Otherwise this PR looks fine, it can go to CI.

cc @MarceloSalazar

@ghost
Copy link
Author

ghost commented Jun 4, 2019

@ganesh-ramachandran How we can fix ARMC5 ? It is not supported anymore, should not be used for new targets. Otherwise this PR looks fine, it can go to CI.

@0xc0170 Updated ARMC5 to ARM and rebased.
However, we think export command for any target have issues while using ARM. Please confirm.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

However, we think export command for any target have issues while using ARM. Please confirm.

mbed export -i uvision6 is having issues?

0xc0170
0xc0170 requested changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one line and ready for CI

targets/TARGET_TOSHIBA/TARGET_TMPM4G9/rtc_api.c Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jun 4, 2019

mbed export -i uvision6 is having issues?

@0xc0170 No, we are trying with `mbed export -i uvision'
May be uvision6 should be no problem.

@ghost
Copy link
Author

ghost commented Jun 6, 2019

mbed export -i uvision6 is having issues?

@0xc0170 mbed export -i uvision6 is working.

@ghost
Copy link
Author

ghost commented Jun 7, 2019

just one line and ready for CI

@0xc0170 possible to start CI?

@ghost
Copy link
Author

ghost commented Jun 27, 2019

just one line and ready for CI

Hi @0xc0170 possible to start CI?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 27, 2019

Starting now!

@mbed-ci
Copy link

mbed-ci commented Jun 27, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

0xc0170
0xc0170 reviewed Jul 3, 2019
View reviewed changes
targets/TARGET_TOSHIBA/TARGET_TMPM4G9/rtc_api.c Outdated

void rtc_free(void)
{
if (flag) { // Check status of RTC peripheral driver is ENABLE or DISABLE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I left the msg here yesterday, this flag - will it work after target resets? shouldn't it access registers?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I left the msg here yesterday, this flag - will it work after target resets? shouldn't it access registers?

@0xc0170, Similar comments were given in other Toshiba targets.
RTC status register is not in Toshiba MCUs. However, verified with RTC initialized status.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 8765225 into ARMmbed:master Jul 5, 2019
@ghost ghost deleted the m4g9_newfeatures branch July 29, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.13.1 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciarmcom @0xc0170 @mbed-ci @adbridge