Cellular: Stack type fixes #10842
Merged
Cellular: Stack type fixes #10842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghseb, thank you for your changes. |
|
@mirelachirica Can you review this change? |
| if (get_property(pdp_type_t_to_cellular_property(pdp_type)) || | ||
| ((pdp_type == IPV4V6_PDP_TYPE && (modem_supports_ipv4 || modem_supports_ipv6)) && !_nonip_req)) { | ||
| // Accept exact matching PDP context type | ||
| if (get_property(pdp_type_t_to_cellular_property(pdp_type))) { |
mirelachirica
approved these changes
Jun 19, 2019
adbridge
approved these changes
Jun 20, 2019
|
Re-running travis as I can't see why it failed. CI also started. |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
|
@ghseb Please fix astyle travis failures (one line needs fixing). We restart CI then |
|
@0xc0170 astyle should be fixed |
|
Ci started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
IPV4V6stack type is not handled properly for Gemalto Cinterion modules.First,
PROPERTY_IPV4V6_STACKis a configurable property and therefore a IPV4V6 PDP type should be accepted only ifPROPERTY_IPV4V6_STACKis set. No specific treatment is required here i think.Additionally
GEMALTO_CINTERION_CellularStack::socket_sendto_implin general should not return an error when_stack_typeisIPV4V6_STACK.Pull request type
Reviewers
Release Notes