Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Fix idle thread stack underflow in debug build #10855

Merged

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Jun 18, 2019

Description

This PR fixes idle thread stack underflow in debug build for all Nuvoton targets.

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

In rtos/mbed_lib.json:
Enlarge idle-thread-stack-size-debug-extra for all Nuvoton targets.

In rtos/TARGET_CORTEX/mbed_rtx_conf.h:
MBED_DEBUG also must be defined for this configuration parameter to take effect.
@ciarmcom ciarmcom requested review from a team June 18, 2019 11:00
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ccli8
Copy link
Contributor Author

ccli8 commented Jun 27, 2019

Any update?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170 0xc0170 merged commit 1cecfa4 into ARMmbed:master Jul 1, 2019
@ccli8 ccli8 deleted the nuvoton_idle_stack_underflow_debug branch July 2, 2019 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants