Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC55S69: fix cosFactor data size in header file #10869

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

mathias-arm
Copy link
Contributor

Description

The file fsl_powerquad_data.h declares several dctXXX_cosFactor arrays with sizes twice larger compared to the actual definitions in fsl_powerquad_data.c.

As an example, in fsl_powerquad_data.h:29, we find:

extern int32_t dct16_cosFactor[32];

Whereas in fsl_powerquad_data.c:459, we find:

int32_t dct16_cosFactor[16] = ...

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@maclobdell

The file 'fsl_powerquad_data.h' declares several dctXXX_cosFactor
arrays with sizes twice larger compared to the actual definitions in
'fsl_powerquad_data.c'.
@flit
Copy link

flit commented Jun 19, 2019

cc @mmahadevan108

@ciarmcom ciarmcom requested review from maclobdell, MarceloSalazar and a team June 19, 2019 21:00
@ciarmcom
Copy link
Member

@mathias-arm, thank you for your changes.
@MarceloSalazar @maclobdell @ARMmbed/mbed-os-maintainers please review.

@mmahadevan108
Copy link
Contributor

Thank you. I will work with the SDK team to fix this issue.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2019

@mmahadevan108 Meanwhile we can accept this patch for upcoming patch release?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 279925b into ARMmbed:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants