Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: fix flex word #10948

Merged
merged 1 commit into from
Jul 4, 2019
Merged

BLE: fix flex word #10948

merged 1 commit into from
Jul 4, 2019

Conversation

AGlass0fMilk
Copy link
Member

Description

Fixed typo causing magnetic flux to be magnetic flex.

💪💪💪

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@trowbridgec
Copy link

💪

@AGlass0fMilk
Copy link
Member Author

💪

💪💪💪

@0Grit
Copy link

0Grit commented Jul 2, 2019

♊️ ??

@ciarmcom ciarmcom requested review from a team July 2, 2019 19:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 2, 2019

@AGlass0fMilk, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@40Grit
Copy link

40Grit commented Jul 3, 2019

@0xc170 is there a PR prefix text for typos?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2019

@0xc170 is there a PR prefix text for typos?

I don't follow?

@40Grit
Copy link

40Grit commented Jul 3, 2019

Do PR titles get turned into release notes still?

If so more context might be provided if this were titled

"Typo: Stop flexing on Tesla 💪💪💪"

Or alternatively

"BLE: fix typo to Stop flexing on Tesla 💪💪💪"

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2019

Yes, it does therefore latter would be better. It should be in our guidelines for git - using module/component preferred:
"BLE: / SPI: headline" as first line in the commit msg is good!

bulislaw
bulislaw approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@0xc0170 0xc0170 changed the title Stop flexing on Tesla 💪💪💪 BLE: Stop flexing on Tesla Jul 4, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 5bc30df into ARMmbed:master Jul 4, 2019
@0xc0170 0xc0170 changed the title BLE: Stop flexing on Tesla BLE: fix flex word Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@AGlass0fMilk @trowbridgec @0Grit @ciarmcom @40Grit @0xc0170 @mbed-ci @bulislaw @pan- @adbridge