Restrict FPGA tests to Arduino form factor #10975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only the Arduino form factor is supported. Support for other form factors will be added in the future.
mprse
approved these changes
Jul 5, 2019
0xc0170
approved these changes
Jul 5, 2019
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
c1728p9
suggested changes
Jul 5, 2019
| @@ -19,6 +19,8 @@ | |||
| #error [NOT_SUPPORTED] Analog in not supported for this target | |||
| #elif !COMPONENT_FPGA_CI_TEST_SHIELD | |||
| #error [NOT_SUPPORTED] FPGA CI Test Shield is needed to run this test | |||
| #elif !TARGET_FF_ARDUINO | |||
There was a problem hiding this comment.
Rather than !TARGET_FF_ARDUINO this should be !defined(MBED_CONF_TARGET_DEFAULT_FORM_FACTOR). This macro is set whenever there is a valid form factor.
|
I added the alternate define in this branch: |
Build in the FPGA tests if either MBED_CONF_TARGET_DEFAULT_FORM_FACTOR or TARGET_FF_ARDUINO is defined.
Thanks @c1728p9. I cherry-picked your commit. This PR should be ready to go. |
c1728p9
approved these changes
Jul 8, 2019
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the Arduino form factor is supported (support for other form factors will be added in the future).
This patch will prevent the compilation of greentea tests for targets with non-arduino form factors (or no form factos at all). In consequence, this patch will fix compilation errors for
EFM32GG11_STK3701andTB_SENSE_12whenFPGA_CI_TEST_SHIELDcomponent is added for all targets (#10965 (comment)).Description
Pull request type
Reviewers
@c1728p9 @mprse @maciejbocianski @jamesbeyond
Release Notes