Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FPGA analog out test #11012

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Remove FPGA analog out test #11012

merged 1 commit into from
Jul 11, 2019

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Jul 10, 2019

Description

Remove the analog out test temporarily due to limitations of the FPGA rev 2 hardware and problems with the test. This test will be added back once the hardware and software problems have been addressed but is being removed here to prevent false failures.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mprse @mrcoulter45 @fkjagodzinski

@c1728p9
Remove FPGA analog out test
8fffb94 
Remove the analog out test temporarily due to limitations of the
FPGA rev 2 hardware.
@ciarmcom ciarmcom requested review from fkjagodzinski, mprse, mrcoulter45 and a team July 10, 2019 07:00
@ciarmcom
Copy link
Member

@c1728p9, thank you for your changes.
@mprse @mrcoulter45 @fkjagodzinski @ARMmbed/mbed-os-test @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2019

CI started

@jeromecoutant
Copy link
Collaborator

Hi
I understand you could add some FW test version when the test will come again?
(to avoid testing it with the current HW)

@mbed-ci
Copy link

mbed-ci commented Jul 10, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mprse
Copy link
Contributor

mprse commented Jul 10, 2019

Test run: FAILED
Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

@0xc0170 The results are unexpected. It looks like something went wrong on CI.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2019 •
edited
Loading

Correct, CI issue, test team is investigating

Affects all current PRs

@mbed-ci
Copy link

mbed-ci commented Jul 10, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mbed-ci
Copy link

mbed-ci commented Jul 10, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 90aaa83 into ARMmbed:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mrcoulter45 mrcoulter45 mrcoulter45 approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

@mprse mprse mprse approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@c1728p9 @ciarmcom @0xc0170 @jeromecoutant @mbed-ci @mprse @mrcoulter45 @fkjagodzinski