Support Nuvoton's new target NUMAKER_IOT_M263A #11122

cyliangtw · 2019-07-30T07:23:41Z

Description

This PR adds support for Nuvoton's new target NUMAKER_IOT_M263A, which is Cortex-M23 without Trustzone based.

Pull request type

[ ] Fix
[ ] Refactor
[x] New Target
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Greentea & CI test log

Pass Greentea test in GCC, ARMCC & IAR tool-chain.
Snippet of Greentea test log as below:

mbedgt: test case report:
| target                  | platform_name     | test suite                                                                           | test case                                                                                         | passed | failed | result | elapsed_time (sec) |
|-------------------------|-------------------|--------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|--------|--------|--------|--------------------|
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | mbed-os-features-device_key-tests-device_key-functionality                           | Device Key - derived key consistency 16 byte key                                                  | 1      | 0      | OK     | 0.16               |
.............................................
stack memory                                                         | 1      | 0      | OK     | 0.0                |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | mbed-os-tests-mbedtls-multi                                                          | Crypto: sha256_multi                                                                              | 1      | 0      | OK     | 0.08               |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | mbed-os-tests-mbedtls-multi                                                          | Crypto: sha256_split                                                                              | 1      | 0      | OK     | 0.02               |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | mbed-os-tests-mbedtls-selftest                                                       | mbedtls_entropy_self_test                                                                         | 1      | 0      | OK     | 0.03               |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | mbed-os-tests-mbedtls-selftest                                                       | mbedtls_sha256_self_test                                                                          | 1      | 0      | OK     | 3.19               |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | mbed-os-tests-mbedtls-selftest                                                       | mbedtls_sha512_self_test                                                                          | 1      | 0      | OK     | 4.69               |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | mbed-os-tests-network-l3ip                                                           | L3IP_START                                                                                        | 1      | 0      | OK     | 0.0                |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | mbed-os-tests-network-l3ip                                                           | L3IP_STOP                                                                                         | 1      | 0      | OK     | 0.0                |
mbedgt: test case results: 670 OK
mbedgt: completed in 2297.04 sec
[mbed] Working path "C:\ARM_mbed\examples\mbed-test" (program)

Pass CI test in GCC, ARMCC & IAR tool-chain.

mbedgt: test suite report:
| target                  | platform_name     | test suite                  | result | elapsed_time (sec) | copy_method |
|-------------------------|-------------------|-----------------------------|--------|--------------------|-------------|
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-api-analogin          | OK     | 19.97              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-api-businout          | OK     | 35.41              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-api-digitalio         | OK     | 20.68              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-api-i2c               | OK     | 21.54              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-api-interruptin       | OK     | 20.41              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-api-pwm_fall          | OK     | 31.68              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-api-pwm_rise          | OK     | 31.67              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-api-pwm_rise_fall     | OK     | 183.88             | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-api-spi               | OK     | 20.82              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-assumptions-analogin  | OK     | 22.84              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-assumptions-digitalio | OK     | 21.32              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-assumptions-i2c       | OK     | 19.0               | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-assumptions-pwm       | OK     | 19.42              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-assumptions-pwmout    | OK     | 19.05              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-assumptions-spi       | OK     | 19.61              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-concurrent-comms      | OK     | 20.85              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-concurrent-gpio       | OK     | 22.54              | default     |
| NUMAKER_IOT_M263A-ARMC6 | NUMAKER_IOT_M263A | tests-concurrent-mixed      | OK     | 21.26              | default     |
mbedgt: test suite results: 18 OK

For details, please open attached log files:
m263_greentea_gcc_0723.log
m263_greentea_iar_0726.log
m263_greentea_arm_0730.log
m263_ci_gcc_0723.log
m263_ci_iar_0723.log
m263_ci_arm_0730.log

ciarmcom · 2019-07-30T09:00:38Z

@cyliangtw, thank you for your changes.
@Ronny-Liu @ARMmbed/mbed-os-maintainers please review.

bulislaw · 2019-07-31T11:21:25Z

targets/TARGET_NUVOTON/TARGET_M261/crypto/crypto-misc.cpp

@@ -0,0 +1,344 @@
+/* mbed Microcontroller Library


@Patater could you review the crypto related parts?

bulislaw

Thanks for that, it looks good. Could you re-license all the files to be Apache? https://os.mbed.com/docs/mbed-os/v5.13/contributing/index.html#licensing

bulislaw · 2019-07-31T11:42:09Z

targets/targets.json

+            "FLASH_CMSIS_ALGO"
+        ],
+        "macros": [
+            "MBED_FAULT_HANDLER_DISABLED",


It's disabled by default. But what's the reason behind this flag here?

@bulislaw , it's mbed_fault_handler.c not support Cortex-M23 in early June. However, last mbed_fault_handler.c seems consider TARGET_M23. Let me do some verification.

@bulislaw , After verification, it could support Cortex-M23 and not disabled it by default. Please see the commit 70c8a3b

bulislaw · 2019-07-31T11:43:16Z

targets/targets.json

+        "release_versions": ["5"],
+        "device_name": "M263KIAAE",
+        "bootloader_supported": true,
+        "tickless-from-us-ticker": true,


That will disable deep sleep, is that necessary?

@bulislaw , not support deep sleep in this stage.

cyliangtw · 2019-08-01T10:09:20Z

@bulislaw , about re-license to be Apache, I updated all hal files to fulfill SPDX-License-Identifier: Apache-2.0 in commit 606eb68

bulislaw

LGTM @ARMmbed/mbed-os-maintainers please have a second look

Ronny-Liu

LGTM

SeppoTakalo · 2019-08-05T12:57:29Z

targets/TARGET_NUVOTON/TARGET_M261/device/M261.h

+  * <b>Copyright Notice</b>
+  *
+  * Copyright (C) 2019 Nuvoton Technology Corp. All rights reserved.
+  */


I don't think this license matches what we expect from contributions.
Please see: https://os.mbed.com/docs/mbed-os/v5.13/contributing/license.html

Do you have any other license available for this file?

@SeppoTakalo , so far, seems many targets device folder still not follow your expectation of license, for ex: mbed-os\targets\TARGET_STM\TARGET_STM32F4\TARGET_MTS_MDOT_F411RE\device .
Anyway, I did re-license files of M261 device folder to fulfill SPDX-License-Identifier: Apache-2.0 in commit d863637

@SeppoTakalo, do you have any concern on this commit d863637 for re-license ?

0xc0170 · 2019-08-09T07:56:04Z

targets/TARGET_NUVOTON/TARGET_M261/device/StdDriver/m261_timer_pwm.c

+ * @brief    Timer PWM Controller(Timer PWM) driver source file
+ *
+ * @copyright (C) 2019 Nuvoton Technology Corp. All rights reserved.
+*****************************************************************************/


Looks like StdDriver is missing the acceptable license. Please add it (requested previously by @SeppoTakalo )

@0xc0170 , @SeppoTakalo ,
StdDriver come from SDK, so we try to keep the same originally for easy maintenance & upgrade.
After refer to other targets, could you accept the license as below:

@copyright (C) 2019 Nuvoton Technology Corp. All rights reserved. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. 3. Neither the name of Nuvoton Technology Corp. nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Looks fine to me (BSD-3 clause license as I understand it).

@0xc0170 , @SeppoTakalo ,
Added acceptable license into std-drivers & register header files in commit a1e8122.
So, all the target relative files should fulfill your request.

0xc0170 · 2019-08-12T14:43:13Z

@cyliangtw Please review travis failures (device_name related). I aborted internal CI for now

cyliangtw · 2019-08-13T01:25:19Z

@0xc0170 , the log show the device_name issue related to index.json of tools\arm_pack_manager, it's resolved in PR Add Nuvoton M261 sub-family #11171

0xc0170 · 2019-08-13T08:43:39Z

@0xc0170 , the log show the device_name issue related to index.json of tools\arm_pack_manager, it's resolved in PR Add Nuvoton M261 sub-family #11171

+1 , the PR was merged today. I'll restart travis now

0xc0170 · 2019-08-13T08:44:23Z

CI restarted

mbed-ci · 2019-08-13T09:42:18Z

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2019-08-13T10:07:47Z

GCC fails to build, please review

[DEBUG] Return: 1
[DEBUG] Output: /tmp/ccaIqElp.s: Assembler messages:
[DEBUG] Output: /tmp/ccaIqElp.s:989: Error: instruction not supported in Thumb16 mode -- `subs r0,r1'
[DEBUG] Output: /tmp/ccaIqElp.s:1055: Error: instruction not supported in Thumb16 mode -- `adds r2,#1'

kjbracey · 2019-08-13T10:09:46Z

That error is #11102, fixed by #11208.

cyliangtw · 2019-08-16T11:42:23Z

@0xc0170 , all travis-ci are success after rebase. Please check.

mbed-ci · 2019-08-22T12:43:19Z

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM

cyliangtw · 2019-08-23T13:57:02Z

@0xc0170 , I added one more commit to avoid GCC tool chain issue mentioned in #10898.
Please start CI again.

0xc0170 · 2019-08-26T07:35:35Z

Ci restarted

mbed-ci · 2019-08-26T08:46:26Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2019-08-26T09:21:25Z

There was an example issue we fixed, restarting the CI now

mbed-ci · 2019-08-26T11:09:37Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 6
Build artifacts

ciarmcom requested review from Ronny-Liu and a team July 30, 2019 09:00

ciarmcom added the needs: review label Jul 30, 2019

bulislaw reviewed Jul 31, 2019

View reviewed changes

bulislaw suggested changes Jul 31, 2019

View reviewed changes

bulislaw approved these changes Aug 1, 2019

View reviewed changes

Ronny-Liu approved these changes Aug 2, 2019

View reviewed changes

SeppoTakalo added needs: CI and removed needs: review labels Aug 5, 2019

SeppoTakalo reviewed Aug 5, 2019

View reviewed changes

0xc0170 added the scope: new-target label Aug 9, 2019

0xc0170 requested changes Aug 9, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: CI labels Aug 9, 2019

0xc0170 approved these changes Aug 12, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Aug 12, 2019

0xc0170 added needs: preceding PR and removed needs: CI labels Aug 14, 2019

cyliangtw force-pushed the nuvoton_m263 branch from a1e8122 to a78b73c Compare August 16, 2019 10:13

0xc0170 added needs: work and removed needs: CI labels Aug 22, 2019

cyliangtw added 13 commits August 23, 2019 18:12

M263: Add Numaker-IoT-M263A target board

e46cf83

M263: delete 2 redundant files

b9a2e06

M263: Fix compile error on analogin/out & crypto-misc

d52fced

M263: Include cmsis core_m23.h for macro __CORTEX_M in M261.h

2596b7c

M263: modify epwm-config-output

a62c877

M263: Fix channel release in analogout_free()

3164095

Fix UNO pin map

d69e7c5

Support InterruptIn class in ci-test/pwm_rise_fall test case

c9006bd

M263 support GCC and IAR toolchain

99e1d0b

re-license all of M261 hal files to be Apache

9d653af

Not disable MBED_FAULT_HANDLE by default after it supports Cortex-M23

2b3fda9

re-license files of M261 device folder to be Apache

23267ba

modify acceptable license term of SDK drivres

e57ed04

cyliangtw force-pushed the nuvoton_m263 branch from ede4921 to e57ed04 Compare August 23, 2019 13:44

Add MBED_FAULT_HANDLER_DISABLED into macros to avoid GCC issue

5a1a25a

0xc0170 added needs: CI and removed needs: work labels Aug 23, 2019

0xc0170 added ready for merge and removed needs: CI labels Aug 26, 2019

0xc0170 merged commit 421ad37 into ARMmbed:master Aug 26, 2019

0xc0170 removed the ready for merge label Aug 26, 2019

ccli8 deleted the nuvoton_m263 branch October 23, 2019 02:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Nuvoton's new target NUMAKER_IOT_M263A #11122

Support Nuvoton's new target NUMAKER_IOT_M263A #11122

cyliangtw commented Jul 30, 2019

ciarmcom commented Jul 30, 2019

bulislaw Jul 31, 2019

bulislaw left a comment

bulislaw Jul 31, 2019

cyliangtw Jul 31, 2019

cyliangtw Aug 1, 2019

bulislaw Jul 31, 2019

cyliangtw Aug 1, 2019

cyliangtw commented Aug 1, 2019

bulislaw left a comment

Ronny-Liu left a comment

SeppoTakalo Aug 5, 2019

cyliangtw Aug 6, 2019

cyliangtw Aug 8, 2019

0xc0170 Aug 9, 2019

cyliangtw Aug 12, 2019

0xc0170 Aug 12, 2019

cyliangtw Aug 12, 2019

0xc0170 commented Aug 12, 2019

cyliangtw commented Aug 13, 2019

0xc0170 commented Aug 13, 2019

0xc0170 commented Aug 13, 2019

mbed-ci commented Aug 13, 2019

0xc0170 commented Aug 13, 2019

kjbracey commented Aug 13, 2019

cyliangtw commented Aug 16, 2019

mbed-ci commented Aug 22, 2019

cyliangtw commented Aug 23, 2019

0xc0170 commented Aug 26, 2019

mbed-ci commented Aug 26, 2019

0xc0170 commented Aug 26, 2019

mbed-ci commented Aug 26, 2019

Support Nuvoton's new target NUMAKER_IOT_M263A #11122

Support Nuvoton's new target NUMAKER_IOT_M263A #11122

Conversation

cyliangtw commented Jul 30, 2019

Description

Pull request type

Reviewers

Greentea & CI test log

ciarmcom commented Jul 30, 2019

Choose a reason for hiding this comment

bulislaw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyliangtw commented Aug 1, 2019

bulislaw left a comment

Choose a reason for hiding this comment

Ronny-Liu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 commented Aug 12, 2019

cyliangtw commented Aug 13, 2019

0xc0170 commented Aug 13, 2019

0xc0170 commented Aug 13, 2019

mbed-ci commented Aug 13, 2019

0xc0170 commented Aug 13, 2019

kjbracey commented Aug 13, 2019

cyliangtw commented Aug 16, 2019

mbed-ci commented Aug 22, 2019

cyliangtw commented Aug 23, 2019

0xc0170 commented Aug 26, 2019

mbed-ci commented Aug 26, 2019

0xc0170 commented Aug 26, 2019

mbed-ci commented Aug 26, 2019