Change stack sizes of threads used in tests. GR_LYCHEE failing CI #11417
Conversation
Tharazi97
force-pushed
the
GR_LYCHEE-stats_CPU
branch
from
d918f4a to
5e788a1
Compare
|
@Tharazi97, thank you for your changes. |
|
Fixing one target but what about the rest? Smaller targets - will this test pass there? |
| #elif defined(TARGET_CY8CKIT_062_WIFI_BT_PSA) | ||
| #define PARALLEL_THREAD_STACK_SIZE 512 | ||
| #else | ||
| #define PARALLEL_THREAD_STACK_SIZE 384 |
There was a problem hiding this comment.
why do we get PARALLEL_THREAD_STACK_SIZE fixed to 512? I think in some case some small target would not fit final compiled the images. GR_LYCHEE is an A9 target, maybe we need to make the macro defines as well in the stats_cpu tests
There was a problem hiding this comment.
We could, but i tried to remove too many #if statements as it was working on STM32F070RB and the size of the stack was reduced to make it pass on this target.
There was a problem hiding this comment.
why do we get
PARALLEL_THREAD_STACK_SIZEfixed to 512? I think in some case some small target would not fit final compiled the images. GR_LYCHEE is an A9 target, maybe we need to make the macro defines as well in the stats_cpu tests
Such targets should be optimized in the way as it was done here:
f24ac50
37bfc9e
|
As I remember the problem was only on NUCLEO_F070RB (16kB RAM) where on GCC its From the other side I thought that it was agreed long time ago that we does not support running tests on targets with less than 32kB RAM (or at least less than 20kB like NUCLEO_L073RZ) So assuming above, this change should be fine |
|
cc @ARMmbed/team-st-mcd |
Tharazi97
force-pushed
the
GR_LYCHEE-stats_CPU
branch
from
5e788a1 to
3b47ce8
Compare
|
For now we can implement it like this and discuss other possibilities. |
| @@ -29,7 +29,12 @@ using namespace utest::v1; | |||
|
|
|||
| DigitalOut led1(LED1); | |||
|
|
|||
| #if defined(__CORTEX_A9) || defined(__CORTEX_M23) || defined(__CORTEX_M33) || defined(__CORTEX_M7) | |||
| #define MAX_THREAD_STACK 512 | |||
| #else | |||
There was a problem hiding this comment.
I don't see the link between core and memory size....?
There was a problem hiding this comment.
Targets with these cores have their RAM enough size.
There was a problem hiding this comment.
Can you add a comment above stating this assumption.
Change stack sizes in test stats_cpu and mbedmicro-rtos-mbed-threads. The value 384 was declared to make this test pass on STM32F070RB, but its main stack value has been changed to 3KB so now it passes this test with 512 stack size. The change was needed to make GR_LYCHEE pass this test on ARM compiler.
Tharazi97
force-pushed
the
GR_LYCHEE-stats_CPU
branch
from
3b47ce8 to
e821c4d
Compare
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Change stack sizes in test stats_cpu and mbedmicro-rtos-mbed-threads. The value 384 was declared to make this test pass on STM32F070RB, but its main stack value has been changed to 3KB so now it passes this test with 512 stack size. The change was needed to make GR_LYCHEE pass this test on ARM toolchain.
Description
Pull request type
Reviewers
@jamesbeyond @maciejbocianski
Release Notes