-
Notifications
You must be signed in to change notification settings - Fork 3k
Add CYW9P62S1_43012EVB_01 board #11715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CYW9P62S1_43012EVB_01 board #11715
Conversation
@miteshdedhia7, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't be better if the commit "adding this target" contains details about the board. I reviewed the code and wondered why QSPI and some other were removed (how this differs from its parent for instance).
tests-mbed_hal-sleep_manager fails, is this known issue? What about testing other toolchains?
@0xc0170 I will add details to these details to the commit message but following is the explanation,
I will add the test reports for other toolchain as soon as possible. |
Notes: - CRC and TRNG are disabled on this board since the MCU on this board does not have the required hardware. - QSPI and QSPIF are temporarily removed due to issues related to supporting the new S25FS512S flash chip we have on this board. These will be enabled as soon as we can get the issues resolved. ARMmbed#11722
fef05b7
to
ecdbdc0
Compare
@miteshdedhia7 all our tests must pass before we accept the board.... |
@0xc0170 The attached greentea report also has the issue #11733. Im re-running the tests on all toolchains again to see if I can get a reliable set of results. @adbridge tests-mbed_hal-sleep_manager is a failure on all existing Cypress targets. To confirm your comment above is that required to pass for this board to be accepted? |
To be enabled yes, but to integrate to master - as long as PR is green (it should be as it's not part of PRs testing). It might be in nightly (will be tracked separately if that is the case). |
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
dynamic test restarted |
@ARMmbed/team-cypress all good with this target addition? |
A bit too late, but for future reference updated logs for all toolchains, armc6 Greentea iar Greentea Additional test failure identified, features-storage-tests-kvstore-static_tests which should be addressed in #11747 since the QSPIF Block is disabled on this device. |
how are |
@0xc0170 Hi Martin, the tests-integration-* suite tests I believe were added recently in 5.14. We are currently internally working on those being enabled and issues addressed on all cypress targets (I believe these fail for all cypress targets). |
It might be worth having this as an issue to be able to track it (not only internally). We shall proceed with this PR |
Description
Add target support for CYW9P62S1_43012EVB_01 board.
Greentea Test Reports:
GT_FT_P6S1_43012EVB_01_GCC.txt
GT_FT_P6S1_43012EVB_01_GCC_NET.txt
Pull request type
Reviewers
@ARMmbed/team-cypress
Release Notes