Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #11769 (Cypress: PWM FPGA test wrong assert) #11776

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Fix for issue #11769 (Cypress: PWM FPGA test wrong assert) #11776

merged 1 commit into from
Oct 31, 2019
+1 −1

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Oct 30, 2019

Description

Implementation of pwmout_read() is not consistent with the requirements.
This function should return the current float-point output duty-cycle in range <0.0f, 1.0f>.
Currently it returns decimal percentage value.

Summary of change

Bug fix.

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@yarbcy @0xc0170

@mprse
Fix for issue ARMmbed#11769 (Cypress: PWM FPGA test wrong assert)
b35a679 
Implementation of pwmout_read() is not consistent with the requirements.
This function should return the current float-point output duty-cycle in range <0.0f, 1.0f>.
Currently it returns decimal percentage value.
@mprse mprse mentioned this pull request Oct 30, 2019
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 requested a review from a team October 31, 2019 10:41
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2019

@ARMmbed/team-cypress Please review

@mprse
Copy link
Contributor Author

mprse commented Oct 31, 2019

We still need a confirmation from @yarbcy that this fix solves the problem with the failing PWM test.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2019

Approved by @yarbcy in the issue, good to go

@0xc0170 0xc0170 merged commit aba8f42 into ARMmbed:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170

Assignees
No one assigned
Labels
devices: cypress release-version: 5.14.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mprse @0xc0170 @mbed-ci