Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to tools for Python 3 compatibility #11921

Merged
merged 5 commits into from
Nov 27, 2019

Conversation

madchutney
Copy link
Contributor

Description

Summary of change

Final changes to support Python 3 in the /tools directory owned by B-Tools.

Documentation

Remove any mention of the tools supporting Python 2 only.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mark-edgeworth
@jamesbeyond


Release Notes

Python 3 is now supported by the tools.

Summary of changes

No functional changes, code should be equivalent.

Impact of changes

Code should be Python 3 compatible

Migration actions required

None

@ciarmcom
Copy link
Member

@madchutney, thank you for your changes.
@jamesbeyond @mark-edgeworth @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 22, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2019

This would be good to have reviewed within today to have in 5.15, please review

@bulislaw
Copy link
Member

@mark-edgeworth @acabarbaye please review

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2019

I spoke to @mark-edgeworth , the update will come tomorrow (internal review/tests found some issues)

Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over-the-shoulder review done with Graham on Monday. All now fixed.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 27, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Nov 27, 2019
@0xc0170 0xc0170 merged commit 57f9a1e into ARMmbed:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants