[LPC4088]: Networking was broking when splitting peripheral RAM into two... #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanm
added a commit
that referenced
this pull request
Dec 9, 2013
[LPC4088]: Networking was broking when splitting peripheral RAM into two...
|
Accepting this a temporary fix, a proper solution will have to rethink static memory allocations, like Andreas suggested. |
yossi2le
pushed a commit
to yossi2le/mbed-os
that referenced
this pull request
Jan 2, 2019
[IOTUC-163] Turn ARM_UC_PAAL_TRACE_ENABLE off by default
lrusinowicz
pushed a commit
to lrusinowicz/mbed-os
that referenced
this pull request
Feb 5, 2019
Updating mbed-os to mbed-os-5.8.3
artokin
pushed a commit
to artokin/mbed-os
that referenced
this pull request
Feb 25, 2019
…cc3d 227cc3d Merge pull request ARMmbed#120 from ARMmbed/sync_with_mbedos_2 88894d1 Follow Mbed OS coding style f3db9a1 (via Mbed OS) Add mbedtls platform setup and teardown to modules 5feb8dd Merge pull request ARMmbed#119 from ARMmbed/sync_with_MbedOS 10d5054 (via Mbed OS) Add missing mbed_lib.json for frameworks and nanostack a344676 Remove references to yotta (ARMmbed#118) 610afda Remove excess tracing (ARMmbed#117) 53382d6 Merge pull request ARMmbed#116 from ARMmbed/IOTTHD-1608 15889cb Use Mbed OS coding style d6eff5c Clarify function signature 587e8de Update message prevalidation API 46f86d4 Add API to set callback for CoAP msg prevalidation (ARMmbed#115) 0eb6630 Merge pull request ARMmbed#114 from ARMmbed/sync_with_mbed_os f75732b (split) Add unit tests for TLSSocket and TLSSocketWrapper git-subtree-dir: features/nanostack/coap-service git-subtree-split: 227cc3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the peripheral RAM was split into two 16 KB sections (AHBSRAM0 and AHBSRAM1) networking stopped to work. The reason is that section AHBSRAM1 is used at two locations in the networking code.
lwip/core/mem.c: allocates a ram heap of size MEM_SIZE (about 16KB aligned)
lwip-eth/arch/lpc17_emac.c: driver data lpc_enetdata is put in AHBSRAM1
When splitting peripheral RAM the total size of AHBSRAM1 is 16KB. This forced lpc_enetdata to be put in main SRAM. Since the Ethernet block in LPC4088 doesn't have access to main SRAM ethernet stopped working.
The fix was to reduce the size of the ram heap used by lwip. In the long run it would be better to avoid defining memory regions at several locations in the code.