Thread: remove methods deprecated in 5.10

[kjbracey]

Summary of changes

Remove various Thread methods that were deprecated in Mbed OS 5.10

Impact of changes

Code using the old methods will no longer compile

Migration actions required

Uses of the following removed Thread methods need to be replaced:

• Thread::signal_set -> Thread::flags_set
• Thread::signal_clr -> ThisThread::flags_clear
• Thread::signal_wait -> ThisThread::flags_wait_xxx
• Thread::wait -> ThisThread::sleep_for
• Thread::wait_until -> ThisThread::sleep_until
• Thread::yield -> ThisThread::yield
• Thread::gettid -> Thread::get_id or ThisThread::get_id
• Thread::attach_idle_hook -> Kernel::attach_idle_hook
• Thread::attach_terminate_hook -> Kernel::attach_thread_terminate_hook

Documentation

None.

---

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

---

[ciarmcom]

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

[adbridge]

@bulislaw could you take a look please.

[bulislaw]

CI started

[mbed-ci]

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_unittests
• jenkins-ci/mbed-os-ci_build-ARM
• jenkins-ci/mbed-os-ci_build-GCC_ARM
• jenkins-ci/mbed-os-ci_build-IAR

[adbridge]

@kjbracey-arm could you take a look at the ci failures please

[adbridge]

@kjbracey-arm bump.....

[kjbracey]

Fixed unit test and rtos signals test.

[0xc0170]

CI started

[mbed-ci]

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_build-ARM
• jenkins-ci/mbed-os-ci_build-GCC_ARM
• jenkins-ci/mbed-os-ci_build-IAR

[0xc0170]

Failures look related, please review

[kjbracey]

PR created to fix driver used in example: ARMmbed/stm-spirit1-rf-driver#10

[kjbracey]

@0xc0170 Only failure I could see was that spirit driver - let me know if you saw anything else.

[adbridge]

Looks like the dependent PR has been merged so we can progress this again.

[adbridge]

CI started

[mbed-ci]

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_build-ARM
• jenkins-ci/mbed-os-ci_build-GCC_ARM
• jenkins-ci/mbed-os-ci_build-IAR

[kjbracey]

New fix PR required: ARMmbed/stm-spirit1-rf-driver#11

[kjbracey]

Beyond that, that's a fix to a driver sub-repo that's referred to by nanostack-border-router. The test hadn't picked up PR 10, so presumably I will need to update the lib file in nanostack-border-router.

(What are the branching rules for example updates atm?)

[adbridge]

(What are the branching rules for example updates atm?)

Mmm that is something that needs revisiting in preparation for 6.0 , as we are now releasing off Master for mbed-os it would make sense to go back to releasing off master for examples too. Also note that we are not updating examples for any of the 6.0 pre-releases.....

[kjbracey]

That Spirit driver fix merged - still need to determine what to do with nanostack-border-router.

I'm seeing other "example build failed" errors in the CI, but not managed to track them down in the logs, or reproduce them locally. Could they be just "give up after first failure on nanostack-border-router"?

[kjbracey]

Border router PR: PelionIoT/nanostack-border-router#204

[mbed-ci]

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts